Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.24] fix: do not tag user-assigned public IP #3529

Merged
merged 1 commit into from Mar 13, 2023
Merged

[release-1.24] fix: do not tag user-assigned public IP #3529

merged 1 commit into from Mar 13, 2023

Conversation

k8s-infra-cherrypick-robot
Copy link

This is an automated cherry-pick of #3527

/assign nilo19

fix: do not tag user-assigned public IP

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Mar 11, 2023
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Mar 11, 2023
Merged
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 11, 2023
@coveralls
Copy link

Coverage Status

Coverage: 79.986%. Remained the same when pulling 4b85e0c on k8s-infra-cherrypick-robot:cherry-pick-3527-to-release-1.24 into b5bb401 on kubernetes-sigs:release-1.24.

@nilo19
Copy link
Contributor

nilo19 commented Mar 11, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 11, 2023
@nilo19
Copy link
Contributor

nilo19 commented Mar 11, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k8s-infra-cherrypick-robot, nilo19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 11, 2023
@nilo19
Copy link
Contributor

nilo19 commented Mar 13, 2023

/kind failing-test

@k8s-ci-robot k8s-ci-robot added kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. and removed do-not-merge/needs-kind labels Mar 13, 2023
@k8s-ci-robot k8s-ci-robot merged commit 22578c4 into kubernetes-sigs:release-1.24 Mar 13, 2023
@nilo19 nilo19 added kind/bug Categorizes issue or PR as related to a bug. and removed kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. labels Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx Awaiting requested review from andyzhangx

@feiskyer feiskyer Awaiting requested review from feiskyer

Assignees

@nilo19 nilo19

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@k8s-infra-cherrypick-robot @coveralls @nilo19 @k8s-ci-robot