Fix nodeAddressesChangeDetected() bug when dual-stack #3586
Conversation
k8s-ci-robot
added
release-note
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lzhecheng The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
✅ Deploy Preview for kubernetes-sigs-cloud-provide-azure canceled.
|
lzhecheng
force-pushed
the
fix-ds-cnm-update-ip
branch
from
60c61ca
to
c45ca32
Compare
|
/test pull-cloud-provider-azure-e2e-ccm-vmss-capz |
In a dual-stack cluster, a Node has 2 internal IPs but current logic doesn't distinguish between these 2. As a result, CNM always assumes that NodeAddresses changed. Signed-off-by: Zhecheng Li <zhechengli@microsoft.com>
lzhecheng
force-pushed
the
fix-ds-cnm-update-ip
branch
from
c45ca32
to
58ff78c
Compare
|
It looks like we don't cover the dual-stack cases in the unit test. |
It's in |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/test pull-cloud-provider-azure-e2e-capz |
|
/retest |
|
/cherrypick release-1.26 |
|
/cherrypick release-1.25 |
|
/cherrypick release-1.24 |
|
/cherrypick release-1.23 |
|
@lzhecheng: new pull request created: #3607 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@lzhecheng: new pull request created: #3608 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@lzhecheng: new pull request created: #3609 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@lzhecheng: new pull request created: #3610 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fix nodeAddressesChangeDetected() bug when dual-stack. In a dual-stack cluster, a Node has 2 internal IPs but current logic doesn't distinguish between these 2. As a result, CNM always assumes that NodeAddresses changed.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: