Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.26] Fix nodeAddressesChangeDetected() bug when dual-stack #3607

Merged
merged 1 commit into from Mar 22, 2023
Merged

[release-1.26] Fix nodeAddressesChangeDetected() bug when dual-stack #3607

merged 1 commit into from Mar 22, 2023

Conversation

k8s-infra-cherrypick-robot
Copy link

This is an automated cherry-pick of #3586

/assign lzhecheng

Fix nodeAddressesChangeDetected() bug when dual-stack. In a dual-stack cluster, a Node has 2 internal IPs but current logic doesn't distinguish between these 2. As a result, CNM always assumes that NodeAddresses changed.

@lzhecheng
Fix nodeAddressesChangeDetected() bug when dual-stack In a dual-stack…
9d2e18b 
… cluster, a Node has 2 internal IPs but current logic doesn't distinguish between these 2. As a result, CNM always assumes that NodeAddresses changed.

Signed-off-by: Zhecheng Li <zhechengli@microsoft.com>
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Mar 22, 2023
Merged
@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Mar 22, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind labels Mar 22, 2023
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 22, 2023
@coveralls
Copy link

Coverage Status

Coverage: 79.362% (+0.008%) from 79.353% when pulling 9d2e18b on k8s-infra-cherrypick-robot:cherry-pick-3586-to-release-1.26 into 705a1f4 on kubernetes-sigs:release-1.26.

@lzhecheng
Copy link
Contributor

/kind bug
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/needs-kind labels Mar 22, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k8s-infra-cherrypick-robot, lzhecheng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 22, 2023
@k8s-ci-robot k8s-ci-robot merged commit a166676 into kubernetes-sigs:release-1.26 Mar 22, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer Awaiting requested review from feiskyer

@nilo19 nilo19 Awaiting requested review from nilo19

Assignees

@lzhecheng lzhecheng

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@k8s-infra-cherrypick-robot @coveralls @lzhecheng @k8s-ci-robot