Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IPv6] Fix CNM not properly handling IPv6 from imds LB #3726

Merged
merged 1 commit into from Apr 14, 2023

Conversation

lzhecheng
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

[IPv6] Fix CNM not properly handling IPv6 from imds LB. imds LB returns IPv6 IPs wrapped by brackets so extra trimming is needed.

Which issue(s) this PR fixes:

Fixes #3725

Special notes for your reviewer:

Does this PR introduce a user-facing change?

[IPv6] Fix CNM not properly handling IPv6 from imds LB. imds LB returns IPv6 IPs wrapped by brackets so extra trimming is needed.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


imds LB returns IPv6 IPs wrapped by brackets so extra
trimming is needed.

Signed-off-by: Zhecheng Li <zhechengli@microsoft.com>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 13, 2023
@netlify
Copy link

netlify bot commented Apr 13, 2023

Deploy Preview for kubernetes-sigs-cloud-provide-azure ready!

Name Link
🔨 Latest commit 2ff03aa
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cloud-provide-azure/deploys/6437bfee1563f4000849438b
😎 Deploy Preview https://deploy-preview-3726--kubernetes-sigs-cloud-provide-azure.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 13, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lzhecheng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 13, 2023
@jwtty
Copy link
Member

jwtty commented Apr 14, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 14, 2023
@k8s-ci-robot k8s-ci-robot merged commit ee7e2bf into kubernetes-sigs:master Apr 14, 2023
19 checks passed
@lzhecheng lzhecheng deleted the fix-ipv6-cnm-imds-lb branch April 14, 2023 02:06
@lzhecheng
Copy link
Contributor Author

/cherrypick release-1.26

@lzhecheng
Copy link
Contributor Author

/cherrypick release-1.25

@lzhecheng
Copy link
Contributor Author

/cherrypick release-1.24

@lzhecheng
Copy link
Contributor Author

/cherrypick release-1.23

@k8s-infra-cherrypick-robot

@lzhecheng: new pull request created: #3727

In response to this:

/cherrypick release-1.26

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot

@lzhecheng: new pull request created: #3728

In response to this:

/cherrypick release-1.25

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot

@lzhecheng: new pull request created: #3729

In response to this:

/cherrypick release-1.24

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot

@lzhecheng: new pull request created: #3730

In response to this:

/cherrypick release-1.23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[IPv6] CNM doesn't properly handle IPv6 addresses from imds load balancer
4 participants