Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add PickRandomMatchingAccount in account search #3811

Merged
merged 3 commits into from Apr 24, 2023
Merged

feat: add PickRandomMatchingAccount in account search #3811

merged 3 commits into from Apr 24, 2023

Conversation

andyzhangx
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR:

  • add PickRandomMatchingAccount in account search
  • add PublicNetworkAccess in disk creation

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

 - add PickRandomMatchingAccount in account search
 - add PublicNetworkAccess in disk creation

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

 - add PickRandomMatchingAccount in account search
 - add PublicNetworkAccess in disk creation

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 23, 2023
@netlify
Copy link

netlify bot commented Apr 23, 2023 •
edited

✅ Deploy Preview for kubernetes-sigs-cloud-provide-azure canceled.

Name Link
🔨 Latest commit 26b399c
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cloud-provide-azure/deploys/644518d3d26dec0008501f3e

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 23, 2023
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 23, 2023
@andyzhangx andyzhangx mentioned this pull request Apr 23, 2023
Closed
@andyzhangx
Copy link
Member Author

/retest

@cvvz
Copy link
Member

cvvz commented Apr 24, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 24, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, cvvz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 30d6089 into kubernetes-sigs:master Apr 24, 2023
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cvvz cvvz cvvz left review comments

@feiskyer feiskyer Awaiting requested review from feiskyer

@MartinForReal MartinForReal Awaiting requested review from MartinForReal

Assignees

@cvvz cvvz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andyzhangx @cvvz @k8s-ci-robot