Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.24] fix: the pip without tags should be user-assigned #3892

Merged

Conversation

nilo19
Copy link
Contributor

@nilo19 nilo19 commented May 17, 2023

What type of PR is this?

/kind bug

What this PR does / why we need it:

  1. PIPs without tags should be treated as user-assigned resources. We should not tag user-assigned pip without tags.
  2. When the svc changes its IP from one to another, the cached pip can be outdated. Need to refresh the cache when necessary.
  3. We should not tag user-assigned pip for DNS labels.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

fix: the pip without tags should be user-assigned
fix: refresh the pip cache when necessary
fix: do not tag user-assigned pip with `kubernetes-dns-label-service: <svcName>`

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


fix: refresh the pip cache when necessary
fix: do not tag user-assigned pip with `kubernetes-dns-label-service: <svcName>`
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 17, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nilo19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 17, 2023
@coveralls
Copy link

Coverage Status

Coverage: 80.3% (+0.03%) from 80.27% when pulling fbf4539 on nilo19:fix/cherry-pick-3877-1.24 into 275d68c on kubernetes-sigs:release-1.24.

@lzhecheng
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 18, 2023
@k8s-ci-robot k8s-ci-robot merged commit 5027b01 into kubernetes-sigs:release-1.24 May 18, 2023
12 checks passed
@nilo19 nilo19 deleted the fix/cherry-pick-3877-1.24 branch May 18, 2023 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants