New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add GetLatestAccountKey in account key fetch #4067
Merged
k8s-ci-robot
merged 1 commit into
kubernetes-sigs:master
from
andyzhangx:GetLatestAccountKey
Jun 9, 2023
Merged
feat: add GetLatestAccountKey in account key fetch #4067
k8s-ci-robot
merged 1 commit into
kubernetes-sigs:master
from
andyzhangx:GetLatestAccountKey
Jun 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
kind/feature
Categorizes issue or PR as related to a new feature.
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
labels
Jun 8, 2023
✅ Deploy Preview for kubernetes-sigs-cloud-provide-azure canceled.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
labels
Jun 8, 2023
andyzhangx
force-pushed
the
GetLatestAccountKey
branch
from
June 8, 2023 11:32
0c3e238
to
5c22d68
Compare
andyzhangx
changed the title
[WIP]feat: add GetLatestAccountKey in account key fetch
feat: add GetLatestAccountKey in account key fetch
Jun 8, 2023
k8s-ci-robot
added
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
and removed
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
labels
Jun 8, 2023
andyzhangx
force-pushed
the
GetLatestAccountKey
branch
from
June 8, 2023 11:33
5c22d68
to
76cef8a
Compare
fix gomod fix revert
andyzhangx
force-pushed
the
GetLatestAccountKey
branch
from
June 8, 2023 11:38
76cef8a
to
80f57a3
Compare
k8s-ci-robot
added
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
and removed
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
labels
Jun 8, 2023
lzhecheng
reviewed
Jun 9, 2023
/lgtm |
k8s-ci-robot
added
the
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
label
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
kind/feature
Categorizes issue or PR as related to a new feature.
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
feat: add GetLatestAccountKey in account key fetch
related to requirement: kubernetes-sigs/azurefile-csi-driver#1218
This PR does not change the default behavior.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: