Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.25] fix: remove deleted node IP address from IP-based LB backend pools #4149

Merged

Conversation

nilo19
Copy link
Contributor

@nilo19 nilo19 commented Jun 21, 2023

What type of PR is this?

/kind bug

What this PR does / why we need it:

We should remove deleted node IPs from the IP-based backend pools.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

fix: remove deleted node IP address from IP-based LB backend pools

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 21, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nilo19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 21, 2023
@nilo19 nilo19 changed the title [release-1.27] fix: remove deleted node IP address from IP-based LB backend pools [release-1.25] fix: remove deleted node IP address from IP-based LB backend pools Jun 21, 2023
@lzhecheng
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 21, 2023
@lzhecheng
Copy link
Contributor

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 21, 2023
@lzhecheng
Copy link
Contributor

Is this duplicate with #4150?

@lzhecheng
Copy link
Contributor

/unhold
Got it. This PR is for 1.25. The other one is for 1.24 but the title is incorrect.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 21, 2023
@k8s-ci-robot k8s-ci-robot merged commit fef632c into kubernetes-sigs:release-1.25 Jun 21, 2023
11 checks passed
@nilo19
Copy link
Contributor Author

nilo19 commented Jun 21, 2023

Is this duplicate with #4150?

No, that one is for v1.24, but I set the wrong title.

@nilo19 nilo19 deleted the fix/cherry-pick-4136-1.25 branch June 21, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants