Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: PerformancePlus setting issue #4193

Merged
merged 1 commit into from Jun 29, 2023

Conversation

andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented Jun 28, 2023

What type of PR is this?

/kind bug

What this PR does / why we need it:

PerformancePlus is not set correctly per kubernetes-sigs/azuredisk-csi-driver#1893, this PR fixes the issue.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

  Normal   ExternalProvisioning  11s              persistentvolume-controller                                                             waiting for a volume to be created, either by external provisioner "disk.csi.azure.com" or manually created by system administrator
  Normal   Provisioning          3s (x3 over 7s)  disk.csi.azure.com_aks-acstor-38086987-vmss000002_4639910e-7ba7-4378-b573-e903bbb56d17  External provisioner is provisioning volume for claim "default/pvc-azuredisk5"
  Warning  ProvisioningFailed    3s (x3 over 6s)  disk.csi.azure.com_aks-acstor-38086987-vmss000002_4639910e-7ba7-4378-b573-e903bbb56d17  failed to provision volume with StorageClass "managed-csi": rpc error: code = Internal desc = Retriable: false, RetryAfter: 0s, HTTPStatusCode: 400, RawError: {
  "error": {
    "code": "BadRequest",
    "message": "The performancePlus flag can only be set on disks at least 512 GB in size."
  }
}


# az disk show --name pvc-87efdcc7-e4d9-4854-9717-d6ee67f35aa5 --resource-group MC_andy-aks126_andy-aks126_eastus2
{
  "burstingEnabled": null,
  "completionPercent": null,
  "creationData": {
    "createOption": "Empty",
    "galleryImageReference": null,
    "imageReference": null,
    "logicalSectorSize": null,
    "performancePlus": true,
    "securityDataUri": null,
    "sourceResourceId": null,
    "sourceUniqueId": null,
    "sourceUri": null,
    "storageAccountId": null,
    "uploadSizeBytes": null
  },
  "dataAccessAuthMode": null,
  "diskAccessId": null,
  "diskIopsReadOnly": null,
  "diskIopsReadWrite": 1500,
  "diskMBpsReadOnly": null,
  "diskMBpsReadWrite": 150,
  "diskSizeBytes": 550829555712,
  "diskSizeGb": 513,

Does this PR introduce a user-facing change?

fix: PerformancePlus setting issue

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

fix: PerformancePlus setting issue

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 28, 2023
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 28, 2023
fix: PerformancePlus setting issue

fix
@andyzhangx
Copy link
Member Author

/retest

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, cvvz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cvvz
Copy link
Member

cvvz commented Jun 29, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 29, 2023
@k8s-ci-robot k8s-ci-robot merged commit 7650475 into kubernetes-sigs:master Jun 29, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants