Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: call availabilitySet.EnsureBackendPoolDeleted in scaleSet.Ensure… #4319

Merged
merged 1 commit into from Jul 21, 2023

Conversation

nilo19
Copy link
Contributor

@nilo19 nilo19 commented Jul 20, 2023

…BackendPoolDeleted when using availability sets and vmType=vmss

What type of PR is this?

/kind bug

What this PR does / why we need it:

fix: call availabilitySet.EnsureBackendPoolDeleted in scaleSet.EnsureBackendPoolDeleted when using availability sets and vmType=vmss

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

fix: call availabilitySet.EnsureBackendPoolDeleted in scaleSet.EnsureBackendPoolDeleted when using availability sets and vmType=vmss

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


…BackendPoolDeleted when using availability sets and vmType=vmss
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 20, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nilo19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 20, 2023
@lzhecheng
Copy link
Contributor

/retest

@lzhecheng
Copy link
Contributor

/test pull-cloud-provider-azure-e2e-ccm-ipv6-capz
/test pull-cloud-provider-azure-e2e-ccm-dualstack-capz

@k8s-ci-robot
Copy link
Contributor

@lzhecheng: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-cloud-provider-azure-check-1-25
  • /test pull-cloud-provider-azure-e2e-capz-1-25
  • /test pull-cloud-provider-azure-e2e-ccm-capz-1-25
  • /test pull-cloud-provider-azure-e2e-ccm-vmss-capz-1-25
  • /test pull-cloud-provider-azure-unit-1-25

Use /test all to run all jobs.

In response to this:

/test pull-cloud-provider-azure-e2e-ccm-ipv6-capz
/test pull-cloud-provider-azure-e2e-ccm-dualstack-capz

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lzhecheng
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 20, 2023
@k8s-ci-robot k8s-ci-robot merged commit de4b993 into kubernetes-sigs:release-1.25 Jul 21, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants