Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate the in-tree cloud provider code to the out-of-tree repo #433

Merged
merged 2 commits into from Dec 16, 2020
Merged

Duplicate the in-tree cloud provider code to the out-of-tree repo #433

merged 2 commits into from Dec 16, 2020

Conversation

nilo19
Copy link
Contributor

@nilo19 nilo19 commented Dec 14, 2020

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake
/kind cleanup

What this PR does / why we need it:
Since only bug fixes could be merged into the in-tree cloud provider from v1.20.0, we need to duplicate the in-tree code to the out-of-tree repo.

Which issue(s) this PR fixes:

Fixes #
Ref: #352

Special notes for your reviewer:

Release note:

Duplicate the in-tree cloud provider code to the out-of-tree repo

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 14, 2020
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 14, 2020
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's check whether CI would be fixed by kubernetes/test-infra#20230

@nilo19
Copy link
Contributor Author

nilo19 commented Dec 15, 2020

/retest

@andyzhangx
Copy link
Member

@nilo19
Copy link
Contributor Author

nilo19 commented Dec 15, 2020

@nilo19 I see the config is still testing against in-tree driver:
https://github.com/kubernetes/test-infra/blob/132d8e19d709ef5f89c2995835156d43718ab94d/config/jobs/kubernetes-sigs/cloud-provider-azure/cloud-provider-azure-config.yaml#L258-L260

try remove the above 2 lines and try again.

thanks for reminding

@andyzhangx
Copy link
Member

/test pull-kubernetes-e2e-azure-disk-vmss-ccm

@nilo19
Copy link
Contributor Author

nilo19 commented Dec 15, 2020

/test pull-cloud-provider-azure-e2e-ccm

@nilo19
Copy link
Contributor Author

nilo19 commented Dec 15, 2020

/test pull-kubernetes-e2e-azure-disk-vmss-ccm

@feiskyer
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 16, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, nilo19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit ab5805d into kubernetes-sigs:master Dec 16, 2020
@nilo19 nilo19 deleted the cleanup/copy-in-tree branch December 16, 2020 02:30
@andyzhangx
Copy link
Member

thanks, csi driver test works now.
Since the code is merged now, could you @nilo19 work on this issue: kubernetes-sigs/azuredisk-csi-driver#616? Once we have new vendoring on CSI driver, CSI driver development would be quite easier, thanks.

@nilo19
Copy link
Contributor Author

nilo19 commented Dec 16, 2020

thanks, csi driver test works now.
Since the code is merged now, could you @nilo19 work on this issue: kubernetes-sigs/azuredisk-csi-driver#616? Once we have new vendoring on CSI driver, CSI driver development would be quite easier, thanks.

sure thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants