New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Duplicate the in-tree cloud provider code to the out-of-tree repo #433
Duplicate the in-tree cloud provider code to the out-of-tree repo #433
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, let's check whether CI would be fixed by kubernetes/test-infra#20230
/retest |
@nilo19 I see the config is still testing against in-tree driver: try remove the above 2 lines and try again. |
thanks for reminding |
/test pull-kubernetes-e2e-azure-disk-vmss-ccm |
/test pull-cloud-provider-azure-e2e-ccm |
/test pull-kubernetes-e2e-azure-disk-vmss-ccm |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feiskyer, nilo19 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
thanks, csi driver test works now. |
sure thing. |
What type of PR is this?
What this PR does / why we need it:
Since only bug fixes could be merged into the in-tree cloud provider from v1.20.0, we need to duplicate the in-tree code to the out-of-tree repo.
Which issue(s) this PR fixes:
Fixes #
Ref: #352
Special notes for your reviewer:
Release note: