fix: add StorageAccountCache to avoid querying storage account frequently #4422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
andyzhangx
changed the title
andyzhangx
force-pushed
the
StorageAccountCache
branch
from
09fded4
to
14fa325
Compare
lzhecheng
reviewed
Aug 7, 2023
andyzhangx
force-pushed
the
StorageAccountCache
branch
from
14fa325
to
bc54df5
Compare
fix golint fix comments fix
andyzhangx
force-pushed
the
StorageAccountCache
branch
from
bc54df5
to
bef7fb1
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
fix: add StorageAccountCache to avoid querying storage account frequently
when one storage acount is exceeding quota limit(100TB), AddStorageAccountTags and RemoveStorageAccountTag are called frequently, that would lead to querying storage account frequently, thus finally lead to account operation throttling, this PR adds a timed cache to avoid this issue, and since
StorageAccountCacheis only for managing tags, it's ok that the data could be outdated due to introducing cache.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: