Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to 2020-06-30/compute #444

Merged
merged 1 commit into from Dec 23, 2020

Conversation

andyzhangx
Copy link
Member

What type of PR is this?
/kind api-change

What this PR does / why we need it:
chore: upgrade to 2020-06-30/compute

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

sed -i 's/2019-12-01\/compute/2020-06-30\/compute/g' ./provider/*.*
sed -i 's/2019-12-01\/compute/2020-06-30\/compute/g' ./mockvmsets/*.*
sed -i 's/2019-12-01\/compute/2020-06-30\/compute/g' ./azureclients/diskclient/*.*
sed -i 's/2019-12-01\/compute/2020-06-30\/compute/g' ./azureclients/vmssclient/*.*
sed -i 's/2019-12-01\/compute/2020-06-30\/compute/g' ./azureclients/vmssvmclient/*.*
sed -i 's/2019-12-01\/compute/2020-06-30\/compute/g' ./azureclients/snapshotclient/*.*
sed -i 's/2019-12-01\/compute/2020-06-30\/compute/g' ./azureclients/vmsizeclient/*.*
sed -i 's/2019-12-01\/compute/2020-06-30\/compute/g' ./azureclients/vmclient/*.*
sed -i 's/2019-12-01\/compute/2020-06-30\/compute/g' ./azureclients/diskclient/mockdiskclient/*.*
sed -i 's/2019-12-01\/compute/2020-06-30\/compute/g' ./azureclients/vmssclient/mockvmssclient/*.*
sed -i 's/2019-12-01\/compute/2020-06-30\/compute/g' ./azureclients/snapshotclient/mocksnapshotclient/*.*
sed -i 's/2019-12-01\/compute/2020-06-30\/compute/g' ./azureclients/vmsizeclient/mockvmsizeclient/*.*
sed -i 's/2019-12-01\/compute/2020-06-30\/compute/g' ./azureclients/vmclient/mockvmclient/*.*
sed -i 's/2019-12-01\/compute/2020-06-30\/compute/g' ./azureclients/vmssvmclient/mockvmssvmclient/*.*

Release note:

none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 22, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 22, 2020
@andyzhangx andyzhangx force-pushed the upgrade-2020-06-30 branch 2 times, most recently from 5cea75d to 1900e5a Compare December 22, 2020 03:34
@andyzhangx
Copy link
Member Author

@nilo19 how to fix this issue, golangci-lint is just a code check tool, why it's included in vendor/modules.txt? We could remove this tool by replacing with github action.

level=error msg="Running error: context loading failed: failed to load program with go/packages: err: exit status 1: stderr: go: inconsistent vendoring in /home/prow/go/src/sigs.k8s.io/cloud-provider-azure:\n\tgithub.com/golangci/golangci-lint@v1.25.0: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt\n\nrun 'go mod vendor' to sync, or use -mod=mod or -mod=readonly to ignore the vendor directory\n"
make: *** [Makefile:164: test-lint] Error 3

also what's the following ut failure:

        	Test:       	TestListWithNextPage
    azure_containerserviceclient_test.go:402: missing call(s) to *mockarmclient.MockInterface.PrepareGetRequest(is anything, is anything) /home/prow/go/src/sigs.k8s.io/cloud-provider-azure/pkg/azureclients/containerserviceclient/azure_containerserviceclient_test.go:386
    azure_containerserviceclient_test.go:402: missing call(s) to *mockarmclient.MockInterface.Send(is anything, is anything) /home/prow/go/src/sigs.k8s.io/cloud-provider-azure/pkg/azureclients/containerserviceclient/azure_containerserviceclient_test.go:387
    azure_containerserviceclient_test.go:402: missing call(s) to *mockarmclient.MockInterface.CloseResponse(is anything, is anything) /home/prow/go/src/sigs.k8s.io/cloud-provider-azure/pkg/azureclients/containerserviceclient/azure_containerserviceclient_test.go:397
    azure_containerserviceclient_test.go:402: aborting test due to missing call(s)
--- FAIL: TestListWithNextPage (0.00s)

@nilo19
Copy link
Contributor

nilo19 commented Dec 22, 2020

@andyzhangx andyzhangx force-pushed the upgrade-2020-06-30 branch 2 times, most recently from 149b4d9 to eb6f148 Compare December 22, 2020 04:02
@andyzhangx
Copy link
Member Author

/test pull-kubernetes-e2e-azure-disk-vmss-ccm

@feiskyer
Copy link
Member

could switch to use https://github.com/kubernetes-sigs/azuredisk-csi-driver/blob/master/hack/verify-golint.sh

yes, let's switch to download the tool directly

@andyzhangx
Copy link
Member Author

andyzhangx commented Dec 22, 2020

After upgrade to go sdk v49.1.0, only following ut failed, is it related to this PR(kubernetes/kubernetes#96211) ? @feiskyer

~/go/src/github.com/kubernetes-sigs/cloud-provider-azure/pkg/azureclients/containerserviceclient# go test
--- FAIL: TestListWithNextPage (0.00s)
    azure_containerserviceclient_test.go:401:
                Error Trace:    azure_containerserviceclient_test.go:401
                Error:          Not equal:
                                expected: 6
                                actual  : 3
                Test:           TestListWithNextPage
    azure_containerserviceclient_test.go:402: missing call(s) to *mockarmclient.MockInterface.PrepareGetRequest(is anything, is anything) /root/go/src/github.com/kubernetes-sigs/cloud-provider-azure/pkg/azureclients/containerserviceclient/azure_containerserviceclient_test.go:386
    azure_containerserviceclient_test.go:402: missing call(s) to *mockarmclient.MockInterface.Send(is anything, is anything) /root/go/src/github.com/kubernetes-sigs/cloud-provider-azure/pkg/azureclients/containerserviceclient/azure_containerserviceclient_test.go:387
    azure_containerserviceclient_test.go:402: missing call(s) to *mockarmclient.MockInterface.CloseResponse(is anything, is anything) /root/go/src/github.com/kubernetes-sigs/cloud-provider-azure/pkg/azureclients/containerserviceclient/azure_containerserviceclient_test.go:397
    azure_containerserviceclient_test.go:402: aborting test due to missing call(s)

@nilo19
Copy link
Contributor

nilo19 commented Dec 22, 2020

for the golangci-lint problem:
#446

@andyzhangx andyzhangx force-pushed the upgrade-2020-06-30 branch 2 times, most recently from 5822efd to 15671f5 Compare December 22, 2020 09:38
upgrade to v49.1.0

go mod vendor

fix golangci issue

fix golangci

fix ut failure

fix test failure

fix ut failure
@andyzhangx
Copy link
Member Author

/retest

@nilo19
Copy link
Contributor

nilo19 commented Dec 23, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 23, 2020
@k8s-ci-robot k8s-ci-robot merged commit d12fc98 into kubernetes-sigs:master Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants