New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade to 2020-06-30/compute #444
chore: upgrade to 2020-06-30/compute #444
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
5cea75d
to
1900e5a
Compare
@nilo19 how to fix this issue, golangci-lint is just a code check tool, why it's included in vendor/modules.txt? We could remove this tool by replacing with github action.
also what's the following ut failure:
|
@andyzhangx I think it is because of this line https://github.com/kubernetes-sigs/cloud-provider-azure/blob/master/hack/verify-golint.sh#L19 |
1900e5a
to
7b28306
Compare
could switch to use https://github.com/kubernetes-sigs/azuredisk-csi-driver/blob/master/hack/verify-golint.sh |
149b4d9
to
eb6f148
Compare
/test pull-kubernetes-e2e-azure-disk-vmss-ccm |
yes, let's switch to download the tool directly |
After upgrade to go sdk v49.1.0, only following ut failed, is it related to this PR(kubernetes/kubernetes#96211) ? @feiskyer
|
for the golangci-lint problem: |
5822efd
to
15671f5
Compare
upgrade to v49.1.0 go mod vendor fix golangci issue fix golangci fix ut failure fix test failure fix ut failure
15671f5
to
452d501
Compare
/retest |
/lgtm |
What type of PR is this?
/kind api-change
What this PR does / why we need it:
chore: upgrade to 2020-06-30/compute
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: