Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add permissions to endpointslices #4446

Merged
merged 1 commit into from Aug 15, 2023

Conversation

nilo19
Copy link
Contributor

@nilo19 nilo19 commented Aug 14, 2023

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #
Related: #4013

Special notes for your reviewer:

Does this PR introduce a user-facing change?

release helm v1.27.7+20230815

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Aug 14, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nilo19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 14, 2023
@@ -13,4 +13,4 @@ maintainers:
name: cloud-provider-azure
sources:
- https://github.com/kubernetes-sigs/cloud-provider-azure
version: 1.27.7
version: 1.27.8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since 1.27.8 is not released, please use 1.27.7 with a date as version. e.g. 1.27.7+20230814
Here is an example PR: https://github.com/kubernetes-sigs/cloud-provider-azure/pull/1745/files

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@lzhecheng
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 15, 2023
@lzhecheng
Copy link
Contributor

/retest

@nilo19
Copy link
Contributor Author

nilo19 commented Aug 15, 2023

/test pull-cloud-provider-azure-e2e-ccm-vmss-capz

@k8s-ci-robot k8s-ci-robot merged commit 87c9602 into kubernetes-sigs:master Aug 15, 2023
12 checks passed
@nilo19 nilo19 deleted the chore/permission branch August 15, 2023 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants