Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add node out-of-service taint when node is shutdown #4508

Merged
merged 1 commit into from Aug 28, 2023

Conversation

jwtty
Copy link
Member

@jwtty jwtty commented Aug 25, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

Add node.kubernetes.io/out-of-service when instance is shutdown so pods can be forcefully deleted. Implement the node non-graceful shutdown feature.

There is a delay between the time node becomes NotReady and cloud provider detects node instance is shutdown, which is caused by cache refresh period. Current cache refresh period is 10min by default. So it can take at most 10min before node shutdown taint and node out-of-service taint are added.

Which issue(s) this PR fixes:

Fixes #3269

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Implement node non-graceful shut down feature. Add "node.kubernetes.io/out-of-service" taint to node when cloud provider determines the node is shutdown.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 25, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jwtty

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2023
@jwtty
Copy link
Member Author

jwtty commented Aug 26, 2023

/retest

pkg/provider/azure.go Show resolved Hide resolved
pkg/provider/azure.go Show resolved Hide resolved
@feiskyer
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 28, 2023
@jwtty
Copy link
Member Author

jwtty commented Aug 28, 2023

/test pull-cloud-provider-azure-e2e-ccm-vmss-multi-slb-capz

@jwtty
Copy link
Member Author

jwtty commented Aug 28, 2023

/cherrypick release-1.26

@k8s-infra-cherrypick-robot

@jwtty: once the present PR merges, I will cherry-pick it on top of release-1.26 in a new PR and assign it to you.

In response to this:

/cherrypick release-1.26

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jwtty
Copy link
Member Author

jwtty commented Aug 28, 2023

/cherrypick release-1.27

@k8s-infra-cherrypick-robot

@jwtty: once the present PR merges, I will cherry-pick it on top of release-1.27 in a new PR and assign it to you.

In response to this:

/cherrypick release-1.27

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jwtty
Copy link
Member Author

jwtty commented Aug 28, 2023

/cherrypick release-1.28

@k8s-infra-cherrypick-robot

@jwtty: once the present PR merges, I will cherry-pick it on top of release-1.28 in a new PR and assign it to you.

In response to this:

/cherrypick release-1.28

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jwtty
Copy link
Member Author

jwtty commented Aug 28, 2023

/test pull-cloud-provider-azure-e2e-ccm-capz

@coveralls
Copy link

Coverage Status

coverage: 80.163% (-0.02%) from 80.185% when pulling 74443ed on jwtty:non-graceful-shutdown into 673def5 on kubernetes-sigs:master.

@k8s-ci-robot k8s-ci-robot merged commit 5758470 into kubernetes-sigs:master Aug 28, 2023
17 checks passed
@jwtty jwtty deleted the non-graceful-shutdown branch August 28, 2023 10:58
@k8s-infra-cherrypick-robot

@jwtty: #4508 failed to apply on top of branch "release-1.26":

Applying: add node out-of-service taint when node is shutdown
Using index info to reconstruct a base tree...
M	pkg/provider/azure.go
M	pkg/provider/azure_test.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/provider/azure_test.go
CONFLICT (content): Merge conflict in pkg/provider/azure_test.go
Auto-merging pkg/provider/azure.go
CONFLICT (content): Merge conflict in pkg/provider/azure.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 add node out-of-service taint when node is shutdown
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-1.26

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot

@jwtty: #4508 failed to apply on top of branch "release-1.27":

Applying: add node out-of-service taint when node is shutdown
Using index info to reconstruct a base tree...
M	pkg/provider/azure.go
M	pkg/provider/azure_test.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/provider/azure_test.go
CONFLICT (content): Merge conflict in pkg/provider/azure_test.go
Auto-merging pkg/provider/azure.go
CONFLICT (content): Merge conflict in pkg/provider/azure.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 add node out-of-service taint when node is shutdown
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-1.27

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot

@jwtty: new pull request created: #4520

In response to this:

/cherrypick release-1.28

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

implement Non Graceful node shutdown feature in CCM
7 participants