New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add node out-of-service taint when node is shutdown #4508
add node out-of-service taint when node is shutdown #4508
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jwtty The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
4391e7e
to
74443ed
Compare
/lgtm |
/test pull-cloud-provider-azure-e2e-ccm-vmss-multi-slb-capz |
/cherrypick release-1.26 |
@jwtty: once the present PR merges, I will cherry-pick it on top of release-1.26 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick release-1.27 |
@jwtty: once the present PR merges, I will cherry-pick it on top of release-1.27 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick release-1.28 |
@jwtty: once the present PR merges, I will cherry-pick it on top of release-1.28 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test pull-cloud-provider-azure-e2e-ccm-capz |
@jwtty: #4508 failed to apply on top of branch "release-1.26":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@jwtty: #4508 failed to apply on top of branch "release-1.27":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@jwtty: new pull request created: #4520 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Add
node.kubernetes.io/out-of-service
when instance is shutdown so pods can be forcefully deleted. Implement the node non-graceful shutdown feature.There is a delay between the time node becomes
NotReady
and cloud provider detects node instance is shutdown, which is caused by cache refresh period. Current cache refresh period is 10min by default. So it can take at most 10min before node shutdown taint and node out-of-service taint are added.Which issue(s) this PR fixes:
Fixes #3269
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: