Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.25] feat: add annotation to control pls creation rg #4676

Merged
merged 1 commit into from Sep 21, 2023
Merged

[release-1.25] feat: add annotation to control pls creation rg #4676

merged 1 commit into from Sep 21, 2023

Conversation

jwtty
Copy link
Member

@jwtty jwtty commented Sep 21, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #
related #4660

Special notes for your reviewer:

Does this PR introduce a user-facing change?

By default, all managed private link service (PLS) are created in the resource group configured by azure config (az.privateLinkServiceResourceGroup or az.ResourceGroup).
Add `ServiceAnnotationPLSResourceGroup = "service.beta.kubernetes.io/azure-pls-resource-group"` to control a specific PLS creation resource group.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 21, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jwtty

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 21, 2023
@jwtty jwtty changed the title [release-1.25] add annotation to control pls creation rg [release-1.25] feat: add annotation to control pls creation rg Sep 21, 2023
@MartinForReal
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 21, 2023
@jwtty
Copy link
Member Author

jwtty commented Sep 21, 2023

/test pull-cloud-provider-azure-e2e-ccm-capz-1-25

1 similar comment
@jwtty
Copy link
Member Author

jwtty commented Sep 21, 2023

/test pull-cloud-provider-azure-e2e-ccm-capz-1-25

@k8s-ci-robot k8s-ci-robot merged commit c3e224f into kubernetes-sigs:release-1.25 Sep 21, 2023
11 of 12 checks passed
@jwtty jwtty deleted the cp_plsrg_new_1.25 branch September 21, 2023 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx Awaiting requested review from andyzhangx

@feiskyer feiskyer Awaiting requested review from feiskyer

Assignees

@MartinForReal MartinForReal

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jwtty @k8s-ci-robot @MartinForReal