[release-1.28] feat: Add annotation service.beta.kubernetes.io/azure-allowed-ip-ranges

[zarvd]

What type of PR is this?

/kind feature

What this PR does / why we need it:

Cherry pick #4762

This PR introduces a new annotation service.beta.kubernetes.io/azure-allowed-ip-ranges to manage the LoadBalancer service access. Previously, it was impossible to restrict access using both IP ranges and service tags (trying to use spec.loadBalancerSourceRanges and service.beta.kubernetes.io/azure-service-tags together didn’t work as one might think). With these changes, we can use service.beta.kubernetes.io/azure-allowed-ip-ranges and service.beta.kubernetes.io/azure-service-tags simultaneously.

Use cases:

limit access with both IP ranges and service tags

apiVersion: v1
kind: Service
metadata:
  name: test-lb
  annotations:
    service.beta.kubernetes.io/azure-allowed-ip-ranges: "192.168.0.1/32,10.20.0.0/16"
    service.beta.kubernetes.io/azure-allowed-service-tags: "AzureCloud"
spec:
  type: LoadBalancer
  ports:
  - port: 80
  selector:
    app: nginx

As expected, three NSG rules will be created. Any source service with the IPs mentioned above, or those tagged with AzureCloud, will be able to access this LoadBalancer service.

specify both spec.loadBalancerSourceRange and the new annotation

apiVersion: v1
kind: Service
metadata:
  name: test-lb
  annotations:
    service.beta.kubernetes.io/azure-allowed-ip-ranges: "192.168.0.1/32,10.20.0.0/16"
spec:
  type: LoadBalancer
  loadBalancerSourceRanges:
    - 1.1.1.1/32
  ports:
  - port: 80
  selector:
    app: nginx

It doesn’t work, as expected.

specify spec.loadBalancerSourceRange and service tags annotation

apiVersion: v1
kind: Service
metadata:
  name: test-lb
  annotations:
    service.beta.kubernetes.io/azure-allowed-service-tags: "AzureCloud"
spec:
  type: LoadBalancer
  loadBalancerSourceRanges:
    - 1.1.1.1/32
  ports:
  - port: 80
  selector:
    app: nginx

Rather than blocking the process of creation or modification, it will generate a warning event.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Introduce the annotation `service.beta.kubernetes.io/azure-allowed-ip-ranges` to manage the LoadBalancer service access.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[k8s-ci-robot]

Hi @lodrem. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[MartinForReal]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lodrem, MartinForReal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [MartinForReal]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[MartinForReal]

@lodrem Could you please squash the commit?

[MartinForReal]

/retest

[zarvd]

/retest

[k8s-ci-robot]

@lodrem: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[MartinForReal]

/retest

[MartinForReal]

/ok-to-test

[MartinForReal]

/lgtm

[zarvd]

/retest

[MartinForReal]

/lgtm