feat: support workload identity setting in static PV mount on AKS #4996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
the
size/XXL
andyzhangx
reviewed
Nov 17, 2023
k8s-ci-robot
added
the
needs-rebase
|
listkeys func is added to account client #5019 |
k8s-ci-robot
added
do-not-merge/contains-merge-commits
and removed
needs-rebase
I've reused this func in the latest commit. |
|
@cvvz Could you please rebase the branch with master? Thanks |
k8s-ci-robot
added
the
needs-rebase
|
related: #5126 |
cvvz
force-pushed
the
support-csi-workload-identity
branch
from
00c93b1
to
0531ae3
Compare
k8s-ci-robot
added
size/L
|
Could you please take another look? Thanks. |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, cvvz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
support workload identity setting in static PV mount on AKS
Which issue(s) this PR fixes:
Fixes
Azure/AKS#3432
Azure/azure-storage-fuse#1049 (comment)
Special notes for your reviewer:
Documentation: https://github.com/kubernetes-sigs/azurefile-csi-driver/pull/1566/files#diff-ba6bdf5d643d138b4a41b51808bf8041b48d4d519ebc3c511b4464d14a6ba639
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: