Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: The case of load balancer name should be ignored when determing … #5254

Merged
merged 2 commits into from Jan 11, 2024

Conversation

nilo19
Copy link
Contributor

@nilo19 nilo19 commented Jan 9, 2024

…if it is an internal load balancer.

(cherry picked from commit d84101a)

What type of PR is this?

/kind bug

What this PR does / why we need it:

fix: The case of load balancer name should be ignored when determing if it is an internal load balancer.

Which issue(s) this PR fixes:

Fixes #5192

Special notes for your reviewer:

Does this PR introduce a user-facing change?

fix: The case of load balancer name should be ignored when determing if it is an internal load balancer.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 9, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nilo19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 9, 2024
@nilo19
Copy link
Contributor Author

nilo19 commented Jan 9, 2024

❯ go mod why go.opentelemetry.io/contrib

go.opentelemetry.io/contrib

sigs.k8s.io/cloud-provider-azure/cmd/cloud-controller-manager/app
k8s.io/apiserver/pkg/server
k8s.io/apiserver/pkg/endpoints/filters
go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp
go.opentelemetry.io/contrib
❯ go mod why go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc

go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc

sigs.k8s.io/cloud-provider-azure/cmd/cloud-controller-manager/app/options
k8s.io/apiserver/pkg/server/options
k8s.io/apiserver/pkg/storage/storagebackend/factory
go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc

@nilo19
Copy link
Contributor Author

nilo19 commented Jan 9, 2024

/retest

6 similar comments
@nilo19
Copy link
Contributor Author

nilo19 commented Jan 10, 2024

/retest

@nilo19
Copy link
Contributor Author

nilo19 commented Jan 10, 2024

/retest

@lzhecheng
Copy link
Contributor

/retest

@nilo19
Copy link
Contributor Author

nilo19 commented Jan 10, 2024

/retest

@nilo19
Copy link
Contributor Author

nilo19 commented Jan 10, 2024

/retest

@nilo19
Copy link
Contributor Author

nilo19 commented Jan 11, 2024

/retest

@lzhecheng
Copy link
Contributor

/test pull-cloud-provider-azure-e2e-capz-1-25
/test pull-cloud-provider-azure-e2e-ccm-capz-1-25

@k8s-ci-robot
Copy link
Contributor

@nilo19: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cloud-provider-azure-e2e-ccm-capz-1-25 9446859 link true /test pull-cloud-provider-azure-e2e-ccm-capz-1-25
pull-cloud-provider-azure-e2e-capz-1-25 9446859 link true /test pull-cloud-provider-azure-e2e-capz-1-25

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nilo19 nilo19 merged commit e7c3ba3 into kubernetes-sigs:release-1.25 Jan 11, 2024
8 of 12 checks passed
@nilo19 nilo19 deleted the fix/cherry-pick-5225-1.25 branch January 11, 2024 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants