Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.25] fix: azure_loadbalancer.go: don't use service.Name, when service is nil #5275

Merged
merged 1 commit into from Jan 12, 2024
Merged

[release-1.25] fix: azure_loadbalancer.go: don't use service.Name, when service is nil #5275

merged 1 commit into from Jan 12, 2024

Conversation

k8s-infra-cherrypick-robot
Copy link

This is an automated cherry-pick of #5266

/assign nilo19

fix: azure_loadbalancer.go: don't use service.Name, when service is nil

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jan 11, 2024
Merged
@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jan 11, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind labels Jan 11, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 11, 2024
@lzhecheng
Copy link
Contributor

/test pull-cloud-provider-azure-e2e-capz-1-25
/test pull-cloud-provider-azure-e2e-ccm-capz-1-25

@lzhecheng
Copy link
Contributor

/test pull-cloud-provider-azure-e2e-ccm-vmss-capz-1-25
/test pull-cloud-provider-azure-e2e-ccm-vmss-ip-lb-capz-1-25

@lzhecheng
Copy link
Contributor

/kind bug
/lgtm
/approve

The trivy failure is due to a cve which we cannot resolve. It results from dependency in k8s lib but they don't want to fix in 1.25.

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed do-not-merge/needs-kind labels Jan 12, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 12, 2024
@lzhecheng lzhecheng merged commit 5ca827d into kubernetes-sigs:release-1.25 Jan 12, 2024
10 of 12 checks passed
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k8s-infra-cherrypick-robot, lzhecheng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx Awaiting requested review from andyzhangx

@jwtty jwtty Awaiting requested review from jwtty

Assignees

@lzhecheng lzhecheng

@nilo19 nilo19

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@k8s-infra-cherrypick-robot @lzhecheng @k8s-ci-robot @nilo19 @damdo