Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.29] Fix getVMManagementTypeByIPConfigurationID() #5970

Merged
merged 1 commit into from Apr 23, 2024
Merged

[release-1.29] Fix getVMManagementTypeByIPConfigurationID() #5970

merged 1 commit into from Apr 23, 2024

Conversation

k8s-infra-cherrypick-robot
Copy link

This is an automated cherry-pick of #5948

/assign feiskyer

Force cache refresh for getVMManagementTypeByIPConfigurationID(). The reason is that when a new standalone VM is included in the cluster, CCM cannot tell its VM type with stale cache.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Apr 19, 2024
Merged
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind labels Apr 19, 2024
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 19, 2024
@MartinForReal
Copy link
Contributor

/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed do-not-merge/needs-kind labels Apr 22, 2024
@lzhecheng @MartinForReal
Fix getVMManagementTypeByIPConfigurationID()
cd68bff 
If VM not existing in cache, force cache refresh again.
If the node is not in the cache, assume the node has joined after
the last cache refresh and attempt to refresh the cache.

Signed-off-by: Zhecheng Li <zhechengli@microsoft.com>
@MartinForReal MartinForReal force-pushed the cherry-pick-5948-to-release-1.29 branch from 91234c6 to cd68bff Compare April 22, 2024 02:17
@MartinForReal
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 22, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k8s-infra-cherrypick-robot, MartinForReal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 22, 2024
@MartinForReal
Copy link
Contributor

/retest

2 similar comments
@feiskyer
Copy link
Member

/retest

@feiskyer
Copy link
Member

/retest

@k8s-ci-robot k8s-ci-robot merged commit f70a7b6 into kubernetes-sigs:release-1.29 Apr 23, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx Awaiting requested review from andyzhangx

@jwtty jwtty Awaiting requested review from jwtty

Assignees

@feiskyer feiskyer

@MartinForReal MartinForReal

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@k8s-infra-cherrypick-robot @MartinForReal @k8s-ci-robot @feiskyer @lzhecheng