Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: only logs rate limiting configurations when rate limit is enabled #609

Merged
merged 1 commit into from Apr 28, 2021
Merged

chore: only logs rate limiting configurations when rate limit is enabled #609

merged 1 commit into from Apr 28, 2021

Conversation

feiskyer
Copy link
Member

@feiskyer feiskyer commented Apr 27, 2021 •
edited

cherry-pick of #608 to release-0.7 (for k8s 1.20).

Release note:

chore: only logs rate limiting configurations when rate limit is enabled

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 27, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 27, 2021
@feiskyer
Copy link
Member Author

feiskyer commented Apr 27, 2021 •
edited

@nilo19 we need to enable pre-submit jobs for cherry-pick PRs. Could you help on it?

@feiskyer
Copy link
Member Author

/test pull-cloud-provider-azure-e2e-1-20

@feiskyer feiskyer merged commit 50f3b99 into kubernetes-sigs:release-0.7 Apr 28, 2021
@feiskyer feiskyer deleted the f7 branch April 28, 2021 02:32
@MartinForReal MartinForReal added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx Awaiting requested review from andyzhangx

@nilo19 nilo19 Awaiting requested review from nilo19

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@feiskyer @k8s-ci-robot @MartinForReal