Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: leave the probe path empty for TCP probes #680

Merged
merged 1 commit into from Jun 28, 2021
Merged

fix: leave the probe path empty for TCP probes #680

merged 1 commit into from Jun 28, 2021

Conversation

nilo19
Copy link
Contributor

@nilo19 nilo19 commented Jun 28, 2021

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Not proactively set the default probe path for non HTTP or HTTPS probes.

Which issue(s) this PR fixes:

Fixes kubernetes/kubernetes#102803

Special notes for your reviewer:

Release note:

fix: leave the probe path empty for TCP probes

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 28, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 28, 2021
@coveralls
Copy link

Coverage Status

Coverage increased (+0.001%) to 79.556% when pulling d37fa6c on nilo19:bug/tcp-probe into 13f66db on kubernetes-sigs:master.

Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks for the fix. Let's also cherry-pick this to stable releases.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 28, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, nilo19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit af56f3f into kubernetes-sigs:master Jun 28, 2021
@nilo19 nilo19 deleted the bug/tcp-probe branch June 28, 2021 12:11
k8s-ci-robot added a commit that referenced this pull request Jun 29, 2021
Cherry pick of #680: fix: leave the probe path empty for TCP probes
k8s-ci-robot added a commit that referenced this pull request Jun 30, 2021
Cherry pick of #680: fix: leave the probe path empty for TCP probes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

400 bad request on Azure cloud provider loadbalancer service TCP health probe (requestpath null)
4 participants