Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure major and minor versions are set correctly #749

Merged
merged 2 commits into from Aug 12, 2021

Conversation

feiskyer
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake
/kind bug

What this PR does / why we need it:

fix: ensure major and minor versions are set correctly.

Example output:

version.Info{Major:"1", Minor:"0+", GitVersion:"v1.0.1-116-g93dee8c35", GitCommit:"93dee8c35bddbff6beabb764725c74d252130c3c", GitTreeState:"", BuildDate:"2021-08-11T08:21:10Z", GoVersion:"go1.16.6", Compiler:"gc", Platform:"darwin/amd64"}

Which issue(s) this PR fixes:

Fixes #744

Special notes for your reviewer:

Release note:

fix: ensure major and minor versions are set correctly

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 11, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 11, 2021
@coveralls
Copy link

coveralls commented Aug 11, 2021

Coverage Status

Coverage remained the same at 80.587% when pulling eda2763 on feiskyer:fix-version into 93dee8c on kubernetes-sigs:master.

@nilo19
Copy link
Contributor

nilo19 commented Aug 12, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 12, 2021
@k8s-ci-robot k8s-ci-robot merged commit f9ab942 into kubernetes-sigs:master Aug 12, 2021
@feiskyer feiskyer deleted the fix-version branch August 12, 2021 05:37
feiskyer added a commit that referenced this pull request Aug 12, 2021
feiskyer added a commit that referenced this pull request Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--version flag reports incorrect version
4 participants