Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix detach disk issue on deleting vmss node #774

Merged

Conversation

andyzhangx
Copy link
Member

What type of PR is this?

/kind bug

What this PR does / why we need it:

fix detach disk issue on deleting node
This PR is a proceeding fix with kubernetes/kubernetes#95177
There was error msg format change when vmss node is in deleting state, this PR tries to fix this issue to make sure detach disk return success on vmss node which is being deleting

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Release note:

fix detach disk issue on deleting vmss node

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 26, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 26, 2021
@andyzhangx
Copy link
Member Author

/retest

@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 80.587% when pulling c0c5b3b on andyzhangx:detach-disk-deleting into 9869e9d on kubernetes-sigs:master.

@andyzhangx
Copy link
Member Author

CI is broken:

level=error msg="Running error: buildir: analysis skipped: errors in package: [cmd/cloud-controller-manager/app/controllermanager.go:44:2: package sigs.k8s.io/cloud-provider-azure/cmd/cloud-controller-manager/app/dynamic imports github.com/fsnotify/fsnotify from implicitly required module; to add missing requirements, run:\n\tgo get github.com/fsnotify/fsnotify@v1.4.9]"
level=info msg="Memory: 1062 samples, avg is 881.1MB, max is 3032.1MB"
level=info msg="Execution took 2m41.561547399s"
make: *** [Makefile:203: test-lint] Error 3
+ EXIT_VALUE=2
+ set +o xtrace

@nilo19

@nilo19
Copy link
Contributor

nilo19 commented Aug 26, 2021

#775 to fix this one

@andyzhangx
Copy link
Member Author

/retest

@nilo19
Copy link
Contributor

nilo19 commented Aug 26, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 26, 2021
@k8s-ci-robot k8s-ci-robot merged commit 3b37826 into kubernetes-sigs:master Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants