Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support creating account if not exists when account name is provided #786

Merged

Conversation

andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented Aug 31, 2021

What type of PR is this?

/kind feature

What this PR does / why we need it:

feat: support creating account if not exists when account name is provided

if accountName is provided, and accountOptions.CreateAccount is set as true(by default false), this PR would create account if not exists

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

/hold

Does this PR introduce a user-facing change?

feat: support creating account if not exists when account name is provided

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

feat: support creating account if not exists when account name is provided

createAccountIfNotExists
@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 31, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 31, 2021
@coveralls
Copy link

coveralls commented Aug 31, 2021

Coverage Status

Coverage increased (+0.01%) to 80.592% when pulling c27fe77 on andyzhangx:createAccountIfNotExists into 2e6c2a2 on kubernetes-sigs:master.

@andyzhangx
Copy link
Member Author

/hold cancel
unit tests are added too

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 1, 2021
@andyzhangx andyzhangx changed the title feat: support creating account if not exists feat: support creating account if not exists when account name is provided Sep 1, 2021
@andyzhangx
Copy link
Member Author

/retest

@nilo19
Copy link
Contributor

nilo19 commented Sep 1, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 1, 2021
@k8s-ci-robot k8s-ci-robot merged commit 12b329c into kubernetes-sigs:master Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants