New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Windows Service initialisation support for Cloud Node Manager #823
Add Windows Service initialisation support for Cloud Node Manager #823
Conversation
# strip the following build constraints/tags: | ||
# //go:build | ||
# // +build \n\n | ||
regexs["go_build_constraints"] = re.compile( | ||
r"^(// \+build.*\n)+\n", re.MULTILINE) | ||
r"^(//(go:build| \+build).*\n)+\n", re.MULTILINE) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This update was copied from the head of K/K, with the new go:build
style tags, this update is required
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Tried this out and it seems to work properly
|
@JoelSpeed thanks for the quick work. |
@JoelSpeed as we only release container images today, would you expect the windows binary be also released in the future? |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feiskyer, JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
It's not strictly required for us, we will build it ourselves, but yes, I would expect it to be an option to have an officially built binary for the node manager at least |
@JoelSpeed thanks for the feedbacks. We would upload the binaries as well in the future releases. |
/cherrypick release-1.1 |
@MartinForReal: #823 failed to apply on top of branch "release-1.1":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR adds support for running the Cloud Node Manager as a Windows Service. This is useful in scenarios where you cannot run the node manager via a daemonset, eg for security or licensing reasons.
In windows builds only, a new flag, defaulted to false, determines whether or not the windows binary should run as a windows service initialiser rather than running as a normal windows exe.
Which issue(s) this PR fixes:
Fixes #800
Special notes for your reviewer:
This is mainly copied from the kube-proxy implementation linked in the original issue. I have yet to get this tested as I don't have access to windows right now. Will make sure to get this appropriately tested before we merge.
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: