Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: only restart all controllers after stopping if needed #832

Merged
merged 1 commit into from Oct 13, 2021
Merged

feat: only restart all controllers after stopping if needed #832

merged 1 commit into from Oct 13, 2021

Conversation

nilo19
Copy link
Contributor

@nilo19 nilo19 commented Oct 8, 2021 •
edited

What type of PR is this?

/kind feature

What this PR does / why we need it:

Introducing an internal config disableCloudProvider in the cloud config file. This one will only be used by AKS and will not be exposed to the end-users.
If set to false, the ccm will restart all controllers after stopping. If set to true, the ccm will keep the controllers stopped and wait for the signal to restart them. There will be a warning message every 10 seconds if all the controllers are stopped until they are restarted.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

feat: only restart all controllers after stopping if needed

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 8, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nilo19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 8, 2021
@coveralls
Copy link

coveralls commented Oct 8, 2021 •
edited

Coverage Status

Coverage remained the same at 80.619% when pulling 8ffbb16 on nilo19:feat/restart into 62e5b10 on kubernetes-sigs:master.

@feiskyer feiskyer added this to the v1.2 milestone Oct 9, 2021
feiskyer
feiskyer reviewed Oct 9, 2021
View reviewed changes
cmd/cloud-controller-manager/app/controllermanager.go Outdated
)

for {
configBytes, err = ioutil.ReadFile(configFilePath)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we continue to use file watch to detect config changes and hence don't need a retry here?

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 9, 2021
@feiskyer
Copy link
Member

/test pull-cloud-provider-azure-e2e-ccm
capz test failure is not related to this change, and it would be tracked by #833.

@feiskyer
Copy link
Member

/test pull-cloud-provider-azure-e2e-ccm-capz

feiskyer
feiskyer reviewed Oct 12, 2021
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 12, 2021
@feiskyer
Copy link
Member

/retest

@feiskyer
Copy link
Member

/test pull-cloud-provider-azure-e2e-ccm-vmss-basic-lb

@k8s-ci-robot k8s-ci-robot merged commit 6bdd6e2 into kubernetes-sigs:master Oct 13, 2021
@nilo19 nilo19 deleted the feat/restart branch October 13, 2021 08:31
@feiskyer
Copy link
Member

the PR needs cherry-pick to other release branches

@MartinForReal
Copy link
Contributor

/cherrypick release-1.1

@MartinForReal
Copy link
Contributor

/cherrypick release-1.0

@k8s-infra-cherrypick-robot
Copy link

@MartinForReal: new pull request could not be created: failed to create pull request against kubernetes-sigs/cloud-provider-azure#release-1.1 from head k8s-infra-cherrypick-robot:cherry-pick-832-to-release-1.1: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between kubernetes-sigs:release-1.1 and k8s-infra-cherrypick-robot:cherry-pick-832-to-release-1.1"}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"}

In response to this:

/cherrypick release-1.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot
Copy link

@MartinForReal: new pull request could not be created: failed to create pull request against kubernetes-sigs/cloud-provider-azure#release-1.0 from head k8s-infra-cherrypick-robot:cherry-pick-832-to-release-1.0: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between kubernetes-sigs:release-1.0 and k8s-infra-cherrypick-robot:cherry-pick-832-to-release-1.0"}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"}

In response to this:

/cherrypick release-1.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer left review comments

@andyzhangx andyzhangx Awaiting requested review from andyzhangx

Assignees

@feiskyer feiskyer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@nilo19 @k8s-ci-robot @coveralls @feiskyer @MartinForReal @k8s-infra-cherrypick-robot