Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip instance not found when decoupling vmss from lb #842

Merged
merged 1 commit into from Oct 14, 2021
Merged

fix: skip instance not found when decoupling vmss from lb #842

merged 1 commit into from Oct 14, 2021

Conversation

nilo19
Copy link
Contributor

@nilo19 nilo19 commented Oct 13, 2021

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #787

Special notes for your reviewer:

Does this PR introduce a user-facing change?

fix: skip instance not found when decoupling vmss from lb

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 13, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nilo19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2021
@coveralls
Copy link

coveralls commented Oct 13, 2021

Coverage Status

Coverage decreased (-0.02%) to 80.308% when pulling 0b7ba30 on nilo19:fix/skip-not-found into 6bdd6e2 on kubernetes-sigs:master.

@feiskyer
Copy link
Member

/lgtm

Let's also cherrypick to old releases and k/k

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 13, 2021
@nilo19
Copy link
Contributor Author

nilo19 commented Oct 14, 2021

/retest

@k8s-ci-robot k8s-ci-robot merged commit 0e62f25 into kubernetes-sigs:master Oct 14, 2021
@nilo19 nilo19 deleted the fix/skip-not-found branch October 14, 2021 01:21
@MartinForReal
Copy link
Contributor

/cherrypick release-1.1

@MartinForReal
Copy link
Contributor

/cherrypick release-1.0

@k8s-infra-cherrypick-robot

@MartinForReal: new pull request created: #1433

In response to this:

/cherrypick release-1.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot

@MartinForReal: new pull request created: #1434

In response to this:

/cherrypick release-1.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More detailed error log about "instance not found"
6 participants