Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: skip instance not found when decoupling vmss from lb #845

Merged
merged 1 commit into from Oct 14, 2021
Merged

fix: skip instance not found when decoupling vmss from lb #845

merged 1 commit into from Oct 14, 2021

Conversation

nilo19
Copy link
Contributor

@nilo19 nilo19 commented Oct 14, 2021 •
edited

(cherry picked from commit 0b7ba30)

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #787

Special notes for your reviewer:

Does this PR introduce a user-facing change?

fix: skip instance not found when decoupling vmss from lb

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 14, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nilo19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2021
@coveralls
Copy link

coveralls commented Oct 14, 2021 •
edited

Coverage Status

Coverage increased (+0.02%) to 80.609% when pulling afeefaf on nilo19:cherry-pick-842-1.1 into 0d57433 on kubernetes-sigs:release-1.1.

@nilo19
Copy link
Contributor Author

nilo19 commented Oct 14, 2021

/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 14, 2021
@nilo19
Copy link
Contributor Author

nilo19 commented Oct 14, 2021

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 14, 2021
feiskyer
feiskyer reviewed Oct 14, 2021
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 14, 2021
@nilo19
Copy link
Contributor Author

nilo19 commented Oct 14, 2021

/retest

@k8s-ci-robot k8s-ci-robot merged commit b3b536c into kubernetes-sigs:release-1.1 Oct 14, 2021
@nilo19 nilo19 deleted the cherry-pick-842-1.1 branch October 15, 2021 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer left review comments

@andyzhangx andyzhangx Awaiting requested review from andyzhangx

Assignees

@feiskyer feiskyer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nilo19 @k8s-ci-robot @coveralls @feiskyer