Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use docker buildx for multi-arch node image #855

Merged
merged 2 commits into from Oct 21, 2021
Merged

chore: use docker buildx for multi-arch node image #855

merged 2 commits into from Oct 21, 2021

Conversation

mainred
Copy link
Contributor

@mainred mainred commented Oct 16, 2021 •
edited

What type of PR is this?

use docker buildx to build multi-arch Linux node image. Before this change, we cannot build cross-platform node image with arch different from the one of the host node.

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

use docker buildx for multi-arch node image

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Oct 16, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @mainred. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 16, 2021
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 16, 2021
@mainred
Copy link
Contributor Author

mainred commented Oct 16, 2021

/ok-to-test

@k8s-ci-robot
Copy link
Contributor

@mainred: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@coveralls
Copy link

coveralls commented Oct 16, 2021 •
edited

Coverage Status

Coverage remained the same at 80.384% when pulling 4bc7380 on mainred:buildx-for-mulit-arch into 8d15ed3 on kubernetes-sigs:master.

feiskyer
feiskyer reviewed Oct 17, 2021
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@feiskyer
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 17, 2021
@mainred
Copy link
Contributor Author

mainred commented Oct 17, 2021

I can run make image push locally successfully, investigating why it keeps faliing.

andyzhangx
andyzhangx reviewed Oct 18, 2021
View reviewed changes
Makefile Show resolved Hide resolved
feiskyer
feiskyer reviewed Oct 18, 2021
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@mainred mainred changed the title use docker buildx for multi-arch node image chore: use docker buildx for multi-arch node image Oct 18, 2021
feiskyer
feiskyer approved these changes Oct 18, 2021
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could you squash the commits?

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, mainred

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 18, 2021
@mainred
Copy link
Contributor Author

mainred commented Oct 19, 2021 •
edited

LGTM. Could you squash the commits?

Done, thanks.. will create cherry-pick to other necessary releases as well.

@mainred
Copy link
Contributor Author

mainred commented Oct 19, 2021

The failed pipeline is saying authorization failure when pushing the image.

#16 ERROR: authorization status: 401: authorization failed
https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cloud-provider-azure/855/pull-cloud-provider-azure-e2e-ccm-capz/1449997913097768960

@feiskyer
Copy link
Member

@CecileRobertMichon do you know why 401 happened on the capz test?

@mainred
Copy link
Contributor Author

mainred commented Oct 20, 2021

/retest

k8s-ci-robot added a commit that referenced this pull request Oct 20, 2021
@k8s-ci-robot
Merge pull request #858 from mainred/docker-buildx-release-1.0
23aa0ab 
cherry-pick of #855 to 1.0: use docker buildx for multi-arch node image
k8s-ci-robot added a commit that referenced this pull request Oct 20, 2021
@k8s-ci-robot
Merge pull request #859 from mainred/docker-buildx-release-1.1
bd9f258 
cherry-pick of #855 to 1.1: use docker buildx for multi-arch node image
k8s-ci-robot added a commit that referenced this pull request Oct 20, 2021
@k8s-ci-robot
Merge pull request #857 from mainred/docker-buildx-release-0.7
803adde 
cherry-pick of #855 to 0.7: use docker buildx for multi-arch node image
@feiskyer
Copy link
Member

/lgtm
/test pull-cloud-provider-azure-e2e-ccm-capz

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 20, 2021
@feiskyer
Copy link
Member

/test pull-cloud-provider-azure-e2e-ccm-capz

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 20, 2021
@feiskyer feiskyer mentioned this pull request Oct 20, 2021
Merged
@feiskyer
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 21, 2021
@feiskyer
Copy link
Member

/retest

@k8s-ci-robot k8s-ci-robot merged commit 5b5f4c4 into kubernetes-sigs:master Oct 21, 2021
@mainred mainred deleted the buildx-for-mulit-arch branch October 21, 2021 13:19
@devigned devigned mentioned this pull request Oct 21, 2021
Closed
@zarvd zarvd mentioned this pull request Dec 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx andyzhangx left review comments

@feiskyer feiskyer feiskyer approved these changes

Assignees

@feiskyer feiskyer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mainred @k8s-ci-robot @coveralls @feiskyer @andyzhangx