chore: Polish node manager image building

[mainred]

What type of PR is this?

What this PR does / why we need it:

Changes included in this PR:

• address part of arm64 support for Windows cloud node manager image and refine the dev doc #829, as arm64 windows image support cannot be achieved as mentioned as a limitation of arm64 support for the Windows nanoserver and servercore images.
• unify both Linux and windows node images with the same repository name, like gcr.io/k8s-staging-provider-azure/azure-cloud-node-manager, and is distinguished by different tag naming patterns. Linux is with tag $TAG-linux-$ARCH, while windows are with tag $TAG-windows-$OSVERSION-$ARCH, for example:

qingchuanhao.azurecr.io/cloud-provider-azure/azure-cloud-node-manager:v1.1.3-linux-amd64
qingchuanhao.azurecr.io/cloud-provider-azure/azure-cloud-node-manager:v1.1.3-windows-1809-amd64

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

null

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[k8s-ci-robot]

Hi @mainred. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[coveralls]

Coverage remained the same at 79.954% when pulling 19b0e43 on mainred:polish-node-manager-image-building into e3c0259 on kubernetes-sigs:master.

[zarvd]

And I notice that azurefile-csi-driver Makefile is tidier and more readable. Maybe we could borrow something from that.

[zarvd]

Makefile target should be $(BIN_DIR)/azure-cloud-node-manager-${ARCH}.exe. Or we don't need the ARCH suffix?

[mainred]

I tested the target respectively by WINDOWS_OSVERSION=1809 ARCH=arm64 make build-node-image-windows with output

CGO_ENABLED=0 GOOS=windows GOARCH=arm64 go build -a -o bin/azure-cloud-node-manager-arm64.exe -ldflags '-s -w -X sigs.k8s.io/cloud-provider-azure/pkg/version.gitVersion=v1.23.0-23-g2ef2d846d -X sigs.k8s.io/cloud-provider-azure/pkg/version.gitCommit=2ef2d846d7ecb982a02d9ce82087ac09acf3badb -X sigs.k8s.io/cloud-provider-azure/pkg/version.gitMajor=1 -X sigs.k8s.io/cloud-provider-azure/pkg/version.gitMinor=23+ -X sigs.k8s.io/cloud-provider-azure/pkg/version.buildDate=2022-01-06T14:52:13Z' ./cmd/cloud-node-manager

and

WINDOWS_OSVERSION=1809 ARCH=amd64 make build-node-image-windows with output

CGO_ENABLED=0 GOOS=windows GOARCH=amd64 go build -a -o bin/azure-cloud-node-manager-amd64.exe -ldflags '-s -w -X sigs.k8s.io/cloud-provider-azure/pkg/version.gitVersion=v1.23.0-23-g2ef2d846d -X sigs.k8s.io/cloud-provider-azure/pkg/version.gitCommit=2ef2d846d7ecb982a02d9ce82087ac09acf3badb -X sigs.k8s.io/cloud-provider-azure/pkg/version.gitMajor=1 -X sigs.k8s.io/cloud-provider-azure/pkg/version.gitMinor=23+ -X sigs.k8s.io/cloud-provider-azure/pkg/version.buildDate=2022-01-06T14:52:13Z' ./cmd/cloud-node-manager

[zarvd]

What i mean is that target should be the name of the binary. (ref: https://www.gnu.org/software/make/manual/html_node/Rule-Introduction.html)

And as the linux version $(BIN_DIR)/azure-cloud-node-manager does not suffix with ARCH...

[mainred]

The doc says usually. Don't you think that will give more complexity to the target?

A target is usually the name of a file that is generated by a program

[zarvd]

Maybe we could remove such alias commands?

[mainred]

The makefile target is really messy previous, and I tried to remove as many of them as possible and leave the ones exposed to customers more clear.

We want to make the Linux node images publishing easier from the customer side by calling, they don't have to do an iteration

push-all-node-images-linux: $(addprefix push-node-image-linux-,$(ALL_ARCH.linux))

[zarvd]

ditto.

[nilo19]

/ok-to-test
/lgtm
/approve

[feiskyer]

@mainred the changes have broken image building in CIs. could you fix it?

[mainred]

Fix is on the way.

[mainred]

/retest

pull-cloud-provider-azure-e2e-ccm-capz failed for authorization failure when pushing windows image to capz registry
pull-cloud-provider-azure-e2e failed for a closed watch by a potential network failure.

[mainred]

/retest

[mainred]

/retest

[feiskyer]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, mainred, nilo19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [feiskyer,nilo19]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[feiskyer]

Thanks for the improvement and adding the docs.