Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #607, #627 and #841 to branch release-0.7 #982

Merged

Conversation

lzhecheng
Copy link
Contributor

@lzhecheng lzhecheng commented Jan 10, 2022

What type of PR is this?

What this PR does / why we need it:

Cherry-pick #607, #627 and #841 to branch release-0.7 to solve flaky tests.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Cherry-pick #607 to solve flaky tests:
* should add all nodes in different agent pools to backends [MultipleAgentPools]: fail to find `backendAddressPoolID` in `lbBackendAddressPoolsIDMap`
* Found no or more than 1 virtual network in resource group same as cluster name
* cannot obtain the master node

Failures e.g.
https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cloud-provider-azure/969/pull-cloud-provider-azure-e2e-ccm-capz-1-20/1479028839588827136

Cherry-pick #627 to solve "get outbound rules" issue
Cherry-pick #841 to solve "not equal 0" issue

Failures e.g.
https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cloud-provider-azure/982/pull-cloud-provider-azure-e2e-ccm-capz-1-20/1480370475220602880

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 10, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @lzhecheng. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 10, 2022
@lzhecheng
Copy link
Contributor Author

@nilo19 please help ok-to-test

@nilo19
Copy link
Contributor

nilo19 commented Jan 10, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 10, 2022
@feiskyer
Copy link
Member

Could you add a release note in the PR description part (inside release note part):

```release-note

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 10, 2022
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 10, 2022
@lzhecheng
Copy link
Contributor Author

This time only 2 tests in pull-cloud-provider-azure-e2e-ccm-capz-1-20 failed:

  • should make outbound IP of pod same as in SLB's outbound rules: outbound rule number should not equal 0
  • should support updating internal IP when updating internal service: WaitServiceExposure() timeout

Added 2 fix commits and trigger the test again.

@lzhecheng lzhecheng changed the title Cherry-pick #607 to branch release-0.7 Cherry-pick #607, #627 and #841 to branch release-0.7 Jan 10, 2022
@nilo19
Copy link
Contributor

nilo19 commented Jan 10, 2022

/lgtm
/approved

@nilo19
Copy link
Contributor

nilo19 commented Jan 10, 2022

/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 10, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lzhecheng, nilo19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2022
@k8s-ci-robot k8s-ci-robot merged commit 7c38771 into kubernetes-sigs:release-0.7 Jan 10, 2022
@lzhecheng lzhecheng deleted the 0.7-fix-capz-tests branch January 10, 2022 07:32
@nilo19
Copy link
Contributor

nilo19 commented Jan 10, 2022

/kind flake

@k8s-ci-robot k8s-ci-robot added the kind/flake Categorizes issue or PR as related to a flaky test. label Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants