-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: reduce node LIST APIs in cloud-node-manager #986
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feiskyer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
aa406ef
to
8b4bb05
Compare
/hold |
/hold cancel Ready for review now. |
/lgtm |
cherry-pick of #986 to release-1.1: reduce node LIST APIs in cloud-node-manager
cherry-pick of #986 to release-1.23: reduce node LIST APIs in cloud-node-manager
cherry-pick of #986 to release-1.0: reduce node LIST APIs in cloud-node-manager
@jackfrancis we have another set of cherry-picks. Need to wait for them |
@jackfrancis v1.23.2, v1.1.5 and v1.0.9 have been released with this change. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Refer the codes below, cloud-node-manager is querying the node every 5 minutes to reconcile its addresses, but this API call is not actually required as there's already informers:
cloud-provider-azure/pkg/nodemanager/nodemanager.go
Lines 178 to 181 in 0e8ef48
Hence, this PR replaces the node LIST with informer LIST, which would reduce the API calls to apiserver.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: