-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor EncryptionConfig
for AWSManagedControlPlane
#2540
Comments
@richardcase: Please ensure the request meets the requirements listed here. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hii @richardcase, I am new to open source and will like to contribute to this project so can you assign it to me. |
Welcome @slayer321, thanks for wanting to work on this issue. If you have any questions feel free to ask on here or in the slack channel. /assign slayer321 |
Hii @richardcase, I made changes in the Ps: I am new to Golang so it is getting a bit difficult for me to understand the problem. |
@slayer321 - feel free to ping me on slack and we can chat. Sometimes with the auto generated code you need to make manual changes so that the code is regenerated properly. |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
@slayer321 - how are you getting on with this? |
Hii @richardcase, Sorry due to some college work I was not able to work on this issue. As you mention ..... when I change the pointers in this struct there are some change in |
@slayer321 - when there are changes to the API definitions (like this change) then you need to run |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
/lifecycle frozen |
/remove-lifecycle frozen |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/area provider/eks
/kind api-change
/kind refactor
/milestone v0.7.0
/help
/priority important-soon
Describe the solution you'd like
You can optionally enable encryption for EKS by supplying details in AWSManagedControlPlane.Spec.EncryptionConfig. As its optional, it is a pointer and marked as optional and omitempty.
If you want to enable encryption, then you must supply the provider and resources. Currently, these are pointers and not marked as required. We should mark these as required using kubebuilder validation and remove the pointers/omitempty.
This was noticed whilst making a change for #2505
Anything else you would like to add:
So perhaps something like this:
This will cause problems with the generated deepcopy and conversion functions which will need to be fixed.
Environment:
The text was updated successfully, but these errors were encountered: