Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Cluster and Machine Controller #125

Merged
merged 1 commit into from
Jan 8, 2019
Merged

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Dec 1, 2018

What this PR does / why we need it:

This PR removes Cluster and Machine Controllers in preparation for migrating to CRDs.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

Fixes part of #83

Special notes for your reviewer:

Once this is merged, provider on the master branch will not be usable. Instead, users have to use releases until #126 isn't merged, which should be very soon considering the biggest part is already done.

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 1, 2018
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 1, 2018
@xmudrii
Copy link
Member Author

xmudrii commented Dec 1, 2018

/hold until #123 and #124 are not merged

@xmudrii xmudrii mentioned this pull request Dec 1, 2018
5 tasks
@xmudrii
Copy link
Member Author

xmudrii commented Dec 1, 2018

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 1, 2018
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 3, 2018
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 1, 2019
@xmudrii
Copy link
Member Author

xmudrii commented Jan 4, 2019

This PR is ready to be merged.

Once this is merged, provider on the master branch will not be usable. Instead, users have to use releases until #126 isn't merged, which should be very soon considering the biggest part is already done.

Note that it's required for this PR to be merged before #126 can be merged.

/hold cancel
/assign @nikhita @alvaroaleman

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 4, 2019
@xmudrii xmudrii changed the title Remove cluster/machine actuators Remove Cluster and Machine Controller Jan 4, 2019
Copy link
Member

@nikhita nikhita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

/hold
Feel free to unhold at your discretion :)

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jan 8, 2019
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nikhita, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xmudrii
Copy link
Member Author

xmudrii commented Jan 8, 2019

Let the party begin 🎈
At this point, until #126 is not merged, master is going to be broken
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 8, 2019
@k8s-ci-robot k8s-ci-robot merged commit ac31413 into master Jan 8, 2019
@xmudrii xmudrii deleted the remove-actuators branch March 17, 2019 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants