-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Cluster and Machine Controller #125
Conversation
/hold |
93bb0e0
to
97cf26c
Compare
97cf26c
to
7978822
Compare
7978822
to
07968ff
Compare
This PR is ready to be merged. Once this is merged, provider on the master branch will not be usable. Instead, users have to use releases until #126 isn't merged, which should be very soon considering the biggest part is already done. Note that it's required for this PR to be merged before #126 can be merged. /hold cancel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/hold
Feel free to unhold at your discretion :)
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nikhita, xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Let the party begin 🎈 |
What this PR does / why we need it:
This PR removes Cluster and Machine Controllers in preparation for migrating to CRDs.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes part of #83
Special notes for your reviewer:
Once this is merged, provider on the master branch will not be usable. Instead, users have to use releases until #126 isn't merged, which should be very soon considering the biggest part is already done.
Release note: