Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Add Release Prow Jobs #60

Closed
3 tasks done
christopherhein opened this issue May 18, 2021 · 11 comments
Closed
3 tasks done

🌱 Add Release Prow Jobs #60

christopherhein opened this issue May 18, 2021 · 11 comments
Assignees

Comments

@christopherhein
Copy link
Member

christopherhein commented May 18, 2021

Prior to the first version being released we need to add to the scripts/ dir the proper release scripts as well as setup Prow release jobs. For now we should have just CAPN covered, we'll eventually create separate jobs for virtualcluster releases.

TODOS:

@christopherhein
Copy link
Member Author

/milestone v0.1.x

@k8s-ci-robot k8s-ci-robot added this to the v0.1.x milestone May 18, 2021
@christopherhein
Copy link
Member Author

@vincepri do you have any examples or guides in how other Cluster API Providers handle releases and what we need to setup? I believe we already have a lot of the tooling in-place but just need to wire it all together.

@vincepri
Copy link
Member

For releases, we usually have a bunch of things setup:

The above was built on top of what the default Makefile was at the time we built the CAPI project with kubebuilder. If you need some sync time happy to jump on Zoom and chat about the steps.

There are also some bits to configure in test-infra, and in the k/k8s.io repositories.

@christopherhein
Copy link
Member Author

christopherhein commented May 24, 2021

@vincepri for the Cloudbuild job, do we need to make our own gcloud project or is this picked up from prow? I guess maybe that is setup here - https://github.com/kubernetes/test-infra/blob/master/config/jobs/image-pushing/k8s-staging-cluster-api.yaml ?

@christopherhein
Copy link
Member Author

/assign

@vincepri
Copy link
Member

@christopherhein Yes the setup is there, you'll also need to request a GCP project like the one in here https://github.com/kubernetes/k8s.io/tree/main/audit/projects/k8s-staging-cluster-api

@christopherhein
Copy link
Member Author

Awesome, thanks that part is what I was missing!

@christopherhein
Copy link
Member Author

I forgot I cleaned up the Makefile in the last PR adding Prow presubmits - https://github.com/kubernetes-sigs/cluster-api-provider-nested/blob/main/Makefile#L300-L351

@christopherhein
Copy link
Member Author

/close

@k8s-ci-robot
Copy link
Contributor

@christopherhein: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@christopherhein
Copy link
Member Author

This was completed across many PRs and testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants