Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add project k8s-staging-cluster-api-nested #2123

Merged

Conversation

christopherhein
Copy link
Member

@christopherhein christopherhein commented Jun 3, 2021

Add k8s-staging-cluster-api-nested project for images build from
https://sigs.k8s.io/cluster-api-provider-nested

Related

XRef kubernetes-sigs/cluster-api-provider-nested#60

Signed-off-by: Chris Hein me@chrishein.com

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 3, 2021
@k8s-ci-robot k8s-ci-robot added area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects wg/k8s-infra do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels Jun 3, 2021
@christopherhein
Copy link
Member Author

Add k8s-staging-cluster-api-nested project for images build from
https://sigs.k8s.io/cluster-api-provider-nested

Signed-off-by: Chris Hein <me@chrishein.com>
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Jun 3, 2021
@christopherhein
Copy link
Member Author

/assign @dims

Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 3, 2021
@dims
Copy link
Member

dims commented Jun 3, 2021

I am working on this now. will let you know when it's ready @christopherhein

@christopherhein
Copy link
Member Author

Thanks @dims appreciate it!

@dims
Copy link
Member

dims commented Jun 3, 2021

/approve
/lgtm

once this merges, it takes some time for the google groups to be created and then i run the scripts to create the other resources.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christopherhein, dims, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 3, 2021
@k8s-ci-robot k8s-ci-robot merged commit e8434fd into kubernetes:main Jun 3, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jun 3, 2021
@christopherhein christopherhein deleted the cluster-api-nested-project branch June 3, 2021 22:05
@dims
Copy link
Member

dims commented Jun 3, 2021

should be ready now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/access Define who has access to what via IAM bindings, role bindings, policy, etc. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants