🌱 Fix deprecated markers across codebase #2393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
Signed-off-by: killianmuldoon <kmuldoon@vmware.com>
killianmuldoon
force-pushed
the
pr-fix-deprecated-markers
branch
from
f5998a9
to
13a6519
Compare
k8s-ci-robot
added
size/S
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2393 +/- ##
==========================================
+ Coverage 60.74% 60.85% +0.11%
==========================================
Files 164 164
Lines 9473 9473
==========================================
+ Hits 5754 5765 +11
+ Misses 3301 3294 -7
+ Partials 418 414 -4
☔ View full report in Codecov by Sentry. |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrischdi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: 7ce31c35c2b4ffdd6a544a6cbd68a667630d9835
|
k8s-ci-robot
added
the
approved
killianmuldoon
commented
Sep 26, 2023
| // This is deprecated and is introduced only for smoother transitions. | ||
| // This will be released in a future release. | ||
| // | ||
| // Deprecated: legacyDefaultNetworkLabel will be removed in a future release. | ||
| legacyDefaultNetworkLabel = "capw.vmware.com/is-default-network" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup to fix deprecated markers across the codebase so that they meet the go api deprecation standard.