Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add legacy capw labels to VirtualMachine for backward compatibility #1483

Closed
lubronzhan opened this issue Mar 16, 2022 · 4 comments
Closed
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@lubronzhan
Copy link
Contributor

lubronzhan commented Mar 16, 2022

/kind feature

Describe the solution you'd like
The label clusterSelectorKey is added to the Machine Object. The label used to be capw.vmware.com instead of capv.vmware.com. This label, as well as nodeSelectorKey are consumed by other components.
Directly replacing the key name of the label could cause disruption during upgrade.
In order to provide a smooth upgrade experience, we should have a deprecating policy about this capw label instead of directly replacing it.

Proposal:

  • Add capw and capv labels to Machine for 1 or 2 major releases.
  • Remove this capw release once most customers are using new CAPV, and other component that consumes capv flag.

Updates:

  • While waiting for PM's input on Deprecation process, start the code change first

Anything else you would like to add:
Cloud Provider vSphere also added capw labels . But it's for label selectors. So Cloud Provider vSphere should directly change the capw to capv label.

Environment:

  • Cluster-api-provider-vsphere version:
  • Kubernetes version: (use kubectl version):
  • OS (e.g. from /etc/os-release):
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 16, 2022
@lubronzhan
Copy link
Contributor Author

/assign @lubronzhan

@srm09
Copy link
Contributor

srm09 commented Mar 18, 2022

@aartij17 Pinging you in case Lubron needs an assist.

@srm09
Copy link
Contributor

srm09 commented May 10, 2022

/close
Merged via #1489

@k8s-ci-robot
Copy link
Contributor

@srm09: Closing this issue.

In response to this:

/close
Merged via #1489

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants