-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add legacy capw
labels to VirtualMachine for backward compatibility
#1483
Labels
kind/feature
Categorizes issue or PR as related to a new feature.
Comments
k8s-ci-robot
added
the
kind/feature
Categorizes issue or PR as related to a new feature.
label
Mar 16, 2022
/assign @lubronzhan |
@aartij17 Pinging you in case Lubron needs an assist. |
This was referenced Mar 23, 2022
lubronzhan
changed the title
Add legacy
Add legacy Mar 23, 2022
capw
label to Machine capw
labels to VirtualMachine for backward compatibility
/close |
@srm09: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This was referenced Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
/kind feature
Describe the solution you'd like
The label clusterSelectorKey is added to the Machine Object. The label used to be
capw.vmware.com
instead ofcapv.vmware.com
. This label, as well asnodeSelectorKey
are consumed by other components.Directly replacing the key name of the label could cause disruption during upgrade.
In order to provide a smooth upgrade experience, we should have a deprecating policy about this
capw
label instead of directly replacing it.Proposal:
capw
andcapv
labels to Machine for 1 or 2 major releases.capw
release once most customers are using new CAPV, and other component that consumescapv
flag.Updates:
Anything else you would like to add:
Cloud Provider vSphere also added capw labels . But it's for label selectors. So Cloud Provider vSphere should directly change the capw to capv label.
Environment:
kubectl version
):/etc/os-release
):The text was updated successfully, but these errors were encountered: