New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MachineNodeHealthyCondition to Machine’s Ready condition #3974
Comments
/milestone v0.4.0 |
IMO adding CNI to cluster sounds like a necessary step to make the cluster usable. And if we always want the cluster to have some CNI solution installed, then making sure that the Machine's Ready condition reflects that prerequisite only solidifies that contract. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-contributor-experience at kubernetes/community. |
/remove-lifecycle stale |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-contributor-experience at kubernetes/community. |
@vincepri @CecileRobertMichon opinions about including this in v1alpha4? |
This shouldn't be a breaking change correct? I'm +1 on getting this in as soon as we can but I don't think it's blocking for v0.4.0 |
Given that we are going to change the semantic of the Ready condition for the machines, from a certain PoV this could be considered breaking (this was at least what we assumed when we decided to not include the the condition in the summary during v1alpha3) |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/lifecycle frozen |
/triage accepted |
/help |
@fabriziopandini: GuidelinesPlease ensure that the issue body includes answers to the following questions:
For more details on the requirements of such an issue, please see here and ensure that they are met. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Is anyone looking into this? I would love to help get this implemented. |
@zawachte AFAIK no one is driving this discussion. |
This issue has not been updated in over 1 year, and should be re-triaged. You can:
For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/ /remove-triage accepted |
/priority important-longterm |
We should fix this |
User Story
As a user, I would like to get a summary of machine status by looking at the machine's ready condition
Detailed Description
#3670 & #3890 introduced the NodeHealthy conditions on machines, however
as per discussion #3670 (comment) we decided to not include this condition in the machine's ready condition and to open an issue outlining the contract changes for v1alpha4.
The impact of this change, if implemented, is that a machine will not get ready until a CNI is installed in the cluster.
Is there any objection to implementing this in v1alpha4? Should we consider backporting?
Anything else you would like to add:
From the conditions proposal:
/kind feature
The text was updated successfully, but these errors were encountered: