Add KCPConditions to control plane Machine’s Ready condition

[fabriziopandini]

User Story

As a user, I would like to get a summary of the control plane machine status by looking at the machine's ready condition

Detailed Description

#3900 & #3922 introduced a set of KCP based conditions on machines, include this condition in the machine's ready condition because KCP is a pluggable component.

However, this decision makes the new conditions, less accessible from the user, and it also makes the status of the machine's ready condition less predictable/not consistent with other objects ready conditions

What about making ready to consider all the conditions existing on the machine?

Anything else you would like to add:

From the conditions proposal:

• A Ready condition SHOULD be provided at object level to represent the overall operational state of the component (and IMO for a machine, this includes having the node with a CNI)
• The Ready condition MUST be based on the summary of more detailed conditions existing on the same object
• An object SHOULD NEVER be in status Ready=True if one of the object's conditions are false or if one of the object dependents is in status Ready=False.

/kind feature

[fabriziopandini]

/milestone v0.4.0
/area control-plane
/area machine

[detiber]

Do we have to worry about this leading to circular dependencies here? Will there be a case where we can't do something in KCP until a Machine is Ready, but the Machine can't be Ready until KCP has performed some operations and can mark the appropriate conditions on the Machine allowing the Machine to become Ready?

[fabriziopandini]

Do we have to worry about this leading to circular dependencies here?

We just went into a major refactor in KCP for getting the conditions always reconciled as a first thing in KCP, so this should not be the case.

However, the challenge is how to make this generic given that control plane is pluggable.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

[fabriziopandini]

/lifecycle frozen

[randomvariable]

/area control-plane

[fabriziopandini]

/triage accepted

[fabriziopandini]

/help

[k8s-ci-robot]

@fabriziopandini:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

• Why are we solving this issue?
• To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
• Does this issue have zero to low barrier of entry?
• How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-triage-robot]

This issue has not been updated in over 1 year, and should be re-triaged.

You can:

• Confirm that this issue is still relevant with /triage accepted (org members only)
• Close this issue with /close

For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/

/remove-triage accepted

[fabriziopandini]

/priority important-longterm

[fabriziopandini]

We discussed this during bug triage, and we think that Machine Ready should be about machine and node, not other things that run on top of the machine (either control plane components or other workloads).

/close

[k8s-ci-robot]

@fabriziopandini: Closing this issue.

In response to this:

We discussed this during bug triage, and we think that Machine Ready should be about machine and node, not other things that run on top of the machine (either control plane components or other workloads).

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.