Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile consilidation to improve maintenance and developer experience #6445

Closed
chrischdi opened this issue Apr 26, 2022 · 5 comments · Fixed by #6443
Closed

Makefile consilidation to improve maintenance and developer experience #6445

chrischdi opened this issue Apr 26, 2022 · 5 comments · Fixed by #6443
Assignees
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@chrischdi
Copy link
Member

User Story

As a maintainer I would like to have as less Makefiles as possible for reducing the effort of syncing changes in-between different Makefiles.

As a developer I would like to use make help for getting an overview about all make targets.

Detailed Description

The file test/infrastructure/docker/Makefile contains lots of duplicate target entries which are equivalent or similar to the ones in Makefile.
Lot's of PRs require equivalent changes for Makefile and test/infrastructure/docker/Makefile:

Some changes may not get replicated to the nested Makefile

[A clear and concise description of what you want to happen.]

Anything else you would like to add:

[Miscellaneous information that will assist in solving the issue.]

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 26, 2022
@chrischdi
Copy link
Member Author

/area cleanup

@k8s-ci-robot
Copy link
Contributor

@chrischdi: The label(s) area/cleanup cannot be applied, because the repository doesn't have them.

In response to this:

/area cleanup

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chrischdi
Copy link
Member Author

/kind cleanup

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Apr 26, 2022
@sbueringer
Copy link
Member

Absolutely +1 from my side :)

@fabriziopandini
Copy link
Member

/assign @chrischdi
given that there is already a PR for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants