🌱 consolidate test/infrastructure/docker/Makefile to Makefile

[chrischdi]

What this PR does / why we need it:

Removes all targets in test/infrastructure/docker/Makefile and replaces them by equivalents in Makefile.

Reduces the effort of maintaining and syncing to the additional Makefile.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

Fixes #6445

TODO:

• squash commits, for now 2 commits to help on reviews

Additional info:

Detailed list of migrated targets:

old makefile target	new makefile target	changes
test	test-capd	-
test-verbose	test-capd-verbose	allows to include additional TEST_ARGS
test-junit	test-capd-junit	-
manager	manager-capd	output to BIN_DIR instead of test/infrastructure/docker/$(BIN_DIR)
generate	generate	integrated into core generate command
generate-go	generate-go-deepcopy-capd	splitted into two targets (as handled in core)
generate-go	generate-go-conversion-capd	-
generate-manifests	generate-manifests-capd	-
docker-pull-prerequisites	docker-pull-prerequisites	did already exist
docker-build	docker-capd-build	-
docker-push	docker-capd-push	-
docker-build-all	docker-capd-build-all	-
docker-build-%	docker-capd-build-%	-
docker-push-all	docker-capd-push-all	-
docker-push-%	docker-capd-push-%	-
docker-push-manifest	docker-capd-push-manifest	-
release	release	did already use old capd release target, does the same via release-manifest-dev modification
manifest-modification	manifest-modification	capd parts got integrated to main Makefile function
release-manifests	release-manifests-dev	directly outputs now to RELEASE_DIR, not anymore to test/infrastructure/docker/out
release-staging	release-capd-staging	may also include core release artifacts, is was always used together
release-staging-nigtly	release-capd-staging-nigtly	may also include core release artifacts, is was always used together
release-alias-tag	release-capd-alias-tag	-
clean-bin	clean-bin	does not cleanup test/infrasturcture/docker/bin however this directory is not in-use anymore.
clean-release	clean-release	does not cleanup test/infrasturcture/docker/bin however this directory is not in-use anymore.
verify	verify / verify-capd	verify executes verify-capd and verify-gen which results into still testing the same.
verify-gen	verify-gen	did already exist and compatible due to generate target to also include capd generate targets.

[chrischdi]

/retitle 🌱 consolidate test/infrastructure/docker/Makefile to Makefile

Open question from my side:

• For now I separated the capd build & push targets to not be included in docker-build-all (instead docker-capd-build-all) and docker-push-all (instead docker-capd-push-all). I can think of users want to push core capi but don't care about capd.

I did not do this for generate because I thought that's not worth it.

[chrischdi]

rebased :-)

[chrischdi]

Rebased the PR

/test all

cc @sbueringer

[sbueringer]

Very nice, a few nits, but otherwise looks good

[chrischdi]

cc @sbueringer : addressed comments and rebased again 😀

[sbueringer]

@chrischdi One comment which should hopefully fix the verify job, otherwise lgtm (feel free to squash)

[sbueringer]

Thank you very much!
We wanted to get rid of that Makefile for a long time :)

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment