Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚠️ Remove old metrics from v1a3 #3464

Merged
merged 1 commit into from Aug 17, 2020
Merged

⚠️ Remove old metrics from v1a3 #3464

merged 1 commit into from Aug 17, 2020

Conversation

wfernandes
Copy link
Contributor

What this PR does / why we need it:
In preparation of revamped metrics and remove burden of memory consumption on tsdbs.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #3327

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 6, 2020
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 6, 2020
@wfernandes
Copy link
Contributor Author

/retest

@vincepri
Copy link
Member

vincepri commented Aug 6, 2020

⚠️ ?

@wfernandes wfernandes changed the title 🌱 Remove old metrics from v1a3 ⚠️ Remove old metrics from v1a3 Aug 6, 2020
vincepri
vincepri approved these changes Aug 6, 2020
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/assign @ncdc
/milestone v0.3.9

@k8s-ci-robot k8s-ci-robot added this to the v0.3.9 milestone Aug 6, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 6, 2020
@vincepri
Copy link
Member

vincepri commented Aug 6, 2020

@wfernandes Seems make modules needs to be run

Remove old metrics from v1a3
4ecd3eb 
In preparation of revamped metrics
@wfernandes
Copy link
Contributor Author

Apologies. I thought I did that but guess I didn't commit it.

@fabriziopandini
Copy link
Member

Given this can avoid memory problems in production
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 17, 2020
@fabriziopandini
Copy link
Member

apidiff output

sigs.k8s.io/cluster-api/controllers/metrics
  Incompatible changes:
  - ClusterControlPlaneReady: removed
  - ClusterFailureSet: removed
  - ClusterInfrastructureReady: removed
  - ClusterKubeconfigReady: removed
  - MachineBootstrapReady: removed
  - MachineInfrastructureReady: removed
  - MachineNodeReady: removed

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 17, 2020 •
edited

@wfernandes: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-cluster-api-apidiff 4ecd3eb link /test pull-cluster-api-apidiff

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vincepri
Copy link
Member

/test pull-cluster-api-e2e

@k8s-ci-robot k8s-ci-robot merged commit 43dd623 into kubernetes-sigs:master Aug 17, 2020
@wfernandes wfernandes deleted the remove-metrics branch August 17, 2020 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincepri vincepri vincepri approved these changes

@benmoss benmoss Awaiting requested review from benmoss

Assignees

@ncdc ncdc

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.3.9
Development

Successfully merging this pull request may close these issues.

Remove current metrics due to memory consumption and loading of TSDBs
5 participants
@wfernandes @vincepri @k8s-ci-robot @fabriziopandini @ncdc