Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix E2E self-hosting E2E test by adding docker mount to control-plane nodes #3675

Merged
merged 1 commit into from
Sep 24, 2020
Merged

🐛 Fix E2E self-hosting E2E test by adding docker mount to control-plane nodes #3675

merged 1 commit into from
Sep 24, 2020

Conversation

fabriziopandini
Copy link
Member

@fabriziopandini fabriziopandini commented Sep 22, 2020 •
edited
Loading

What this PR does / why we need it:
This PR fixes a flake in self-hosting failing when CAPD controller gets scheduler on the control-plane nodes.

Those nodes were is missing the mounts for the docker socket, so CAPD was falling to reconcile existing machines after move.

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 22, 2020
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 22, 2020
@fabriziopandini
Copy link
Member Author

/test pull-cluster-api-e2e-full
/area testing

@k8s-ci-robot k8s-ci-robot added the area/testing Issues or PRs related to testing label Sep 22, 2020
@fabriziopandini
Copy link
Member Author

/test pull-cluster-api-e2e-full

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 24, 2020 •
edited
Loading

@fabriziopandini: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-cluster-api-verify-external-links c599e96 link /test pull-cluster-api-verify-external-links

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@fabriziopandini fabriziopandini force-pushed the increase-sync-frequency-to-fix-e2e-flakes branch from c599e96 to 730cf32 Compare September 24, 2020 18:40
@fabriziopandini
Copy link
Member Author

/test pull-cluster-api-e2e-full

@fabriziopandini fabriziopandini force-pushed the increase-sync-frequency-to-fix-e2e-flakes branch from 730cf32 to e59acfa Compare September 24, 2020 19:45
@fabriziopandini
Copy link
Member Author

/test pull-cluster-api-e2e-full

@fabriziopandini fabriziopandini changed the title 🌱 Increase sync freq to fix self-hosting flakes 🐛 Fix E2E self-hosting E2E test by adding docker mount to control-plane nodes Sep 24, 2020
@fabriziopandini
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 24, 2020
vincepri
vincepri approved these changes Sep 24, 2020
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm
/milestone v0.3.10

@k8s-ci-robot k8s-ci-robot added this to the v0.3.10 milestone Sep 24, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 24, 2020
@k8s-ci-robot k8s-ci-robot merged commit f06e210 into kubernetes-sigs:master Sep 24, 2020
@sedefsavas sedefsavas mentioned this pull request Sep 28, 2020
Closed
@fabriziopandini fabriziopandini deleted the increase-sync-frequency-to-fix-e2e-flakes branch September 30, 2020 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincepri vincepri vincepri approved these changes

@CecileRobertMichon CecileRobertMichon Awaiting requested review from CecileRobertMichon

@ncdc ncdc Awaiting requested review from ncdc

Assignees

@vincepri vincepri

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/testing Issues or PRs related to testing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v0.3.10
Development

Successfully merging this pull request may close these issues.
3 participants
@fabriziopandini @k8s-ci-robot @vincepri