Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃尡 Add Kubernetes conformance E2E test #3811

Conversation

fabriziopandini
Copy link
Member

What this PR does / why we need it:
This PR adds an E2E running Kubernetes conformance on CAPD provisioned machines

Which issue(s) this PR fixes:
Rif #3693

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 16, 2020
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 16, 2020
@fabriziopandini
Copy link
Member Author

/test pull-cluster-api-e2e-full-main

Copy link

@sedefsavas sedefsavas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits, otherwise lgtm.

test/e2e/k8s_conformance.go Show resolved Hide resolved
test/e2e/k8s_conformance.go Show resolved Hide resolved
test/e2e/k8s_conformance.go Outdated Show resolved Hide resolved
test/e2e/k8s_conformance.go Show resolved Hide resolved
@fabriziopandini
Copy link
Member Author

/milestone v0.4.0

@k8s-ci-robot k8s-ci-robot added this to the v0.4.0 milestone Nov 16, 2020
@fabriziopandini fabriziopandini force-pushed the add-K8s-conformance-e2e-test branch 2 times, most recently from 1c6e268 to caea0fe Compare November 16, 2020 08:34
@fabriziopandini
Copy link
Member Author

/test pull-cluster-api-e2e-full-main

@wfernandes
Copy link
Contributor

/lgtm
I ran the conformance-fast.yaml and it passed after 31m34.568316096s!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 18, 2020
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Nov 30, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 1, 2020
@fabriziopandini
Copy link
Member Author

rebased and added comment on host.docker.internal

@fabriziopandini
Copy link
Member Author

/test pull-cluster-api-e2e-full-main

@wfernandes
Copy link
Contributor

Seems like the changes were just comments.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 1, 2020
@randomvariable
Copy link
Member

/lgtm

Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 15, 2020
@k8s-ci-robot k8s-ci-robot merged commit 1979640 into kubernetes-sigs:master Dec 15, 2020
@fabriziopandini fabriziopandini deleted the add-K8s-conformance-e2e-test branch December 16, 2020 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants