-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 improve quickstart documentation #4898
📖 improve quickstart documentation #4898
Conversation
Signed-off-by: Stefan Büringer buringerst@vmware.com
@@ -647,7 +647,7 @@ kubeadmconfigtemplate.bootstrap.cluster.x-k8s.io/capi-quickstart-md-0 created | |||
The cluster will now start provisioning. You can check status with: | |||
|
|||
```bash | |||
kubectl get cluster --all-namespaces | |||
kubectl get cluster |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We only have one cluster which we deploy in the default namespace so --all-namespaces is not required here. We also have other kubectl commands in the guide which assume the default namespace (like delete cluster below)
lgtm |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Stefan Büringer buringerst@vmware.com
What this PR does / why we need it:
Just went through the quickstart documentation and I have some suggestions to improve them a bit. See my comments below.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #