-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ implement ClusterReconciler.clusterClassToCluster function #5082
✨ implement ClusterReconciler.clusterClassToCluster function #5082
Conversation
/assign @fabriziopandini |
7bd46c0
to
683c0ad
Compare
/retest |
/lgtm |
lgtm; could you kindly add a unit test? |
/area topology |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Since this PR is already merged, I will create a follow-up PR to add some unit tests around this. |
What this PR does / why we need it:
Implements the
ClusterReconciler.clusterClassToCluster
function.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #5076