🌱 clusterctl describe show MachineSets #5438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
vincepri
reviewed
Oct 18, 2021
| @@ -56,6 +56,7 @@ type describeClusterOptions struct { | |||
|
|
|||
| namespace string | |||
| showOtherConditions string | |||
| showMachineSets bool | |||
There was a problem hiding this comment.
Do we need a new flag for this? Why not include it by default?
There was a problem hiding this comment.
Originally it was decided to hide machine sets to keep the output of describe short and concise (and MS are kind of a internal detail). This flag it is intended to override this initial assumption when required for debugging/troubleshooting
sbueringer
reviewed
Oct 19, 2021
fabriziopandini
force-pushed
the
clusterctl-describe-show-machinesets
branch
from
a2c11f3
to
ce7c4b1
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR makes
clusterctl describeto show MachineSets in the object tree when--show-machinesetsflag is provided*Which issue(s) this PR fixes:
Rif #5346